Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch support in snapshots #12692

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Branch support in snapshots #12692

merged 2 commits into from
Oct 23, 2018

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Oct 22, 2018

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@hansl
ci: snapshots can push to specific branches
8d49c19 
Can take either a branch argument, or use CIRCLE_BRANCH if available.
@googlebot
Copy link

CLAs look good, thanks!

@hansl hansl requested a review from filipesilva October 23, 2018 13:31
@hansl hansl added the target: patch This PR is targeted for the next patch release label Oct 23, 2018
@hansl hansl removed the cla: yes label Oct 23, 2018
@kyliau kyliau merged commit a53cf44 into angular:master Oct 23, 2018
kyliau pushed a commit that referenced this pull request Oct 23, 2018
@hansl @kyliau
Branch support in snapshots (#12692)
8905a4d 
* ci: snapshots can push to specific branches

Can take either a branch argument, or use CIRCLE_BRANCH if available.

* ci: run snapshots on all branches
@hansl hansl deleted the snapshots-branch branch November 28, 2018 23:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hansl @googlebot @filipesilva @kyliau