Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update typescript to 3.1.3 #12612

Merged
merged 3 commits into from
Oct 16, 2018
Merged

update typescript to 3.1.3 #12612

merged 3 commits into from
Oct 16, 2018

Conversation

alan-agius4
Copy link
Collaborator

This lands a fix for this issue microsoft/TypeScript#27341

And solves the problem encountered by @FrozenPandaz

ERROR in /Users/jason/projects/nx/tmp/proj/node_modules/@nrwl/nx/esm5/src/data-persistence.js
Module build failed (from /Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/src/build-optimizer/webpack-loader.js):
Error: Debug Failure.
    at Object.assertDefined (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:1433:24)
    at getJSDocHost (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:10071:25)
    at getHostSignatureFromJSDoc (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:10056:46)
    at Object.getParameterSymbolFromJSDoc (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:10047:20)
    at checkJSDocParameterTag (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:52309:21)
    at checkSourceElement (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:55041:28)
    at Object.forEach (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:210:30)
    at /Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:54965:31
    at Object.forEach (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:210:30)
    at checkSourceElement (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:54963:20)
    at Object.forEach (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:210:30)
    at checkBlock (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:52711:20)
    at checkSourceElement (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:55066:28)
    at checkIfStatement (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:53109:13)
    at checkSourceElement (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:55072:28)
    at Object.forEach (/Users/jason/projects/nx/tmp/proj/node_modules/@angular-devkit/build-optimizer/node_modules/typescript/lib/typescript.js:210:30)

clydin
clydin previously requested changes Oct 16, 2018
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well go up to 3.1.3

@alan-agius4 alan-agius4 changed the title update typescript to 3.1.2 update typescript to 3.1.3 Oct 16, 2018
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 16, 2018
@alexeagle alexeagle merged commit 915994d into angular:master Oct 16, 2018
@alan-agius4 alan-agius4 deleted the fix_typescript branch October 16, 2018 18:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants