Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module.id issue angular 5 compilation process with AngularCompilerPlugin. #8295

Closed
kenneth-igaw opened this issue Nov 2, 2017 · 4 comments · Fixed by #12503
Closed

module.id issue angular 5 compilation process with AngularCompilerPlugin. #8295

kenneth-igaw opened this issue Nov 2, 2017 · 4 comments · Fixed by #12503
Labels
needs: investigation Requires some digging to determine if action is needed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Comments

@kenneth-igaw
Copy link

kenneth-igaw commented Nov 2, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

angular: "5.0.0"
angular/cli: "1.5.0-rc.8"
ngtools/webpack: "1.8.0-rc.8"

Repro steps.

webpack building with AngularCompilerPlugin

The log given by the failure.

Error: moduleId should be a string in "{ComponentName}"

Desired functionality.

Mention any other details that might be useful.

Hello!

I faced an error as follows

Error: moduleId should be a string in "{ComponentName}"

I changed webpack plugin AotPlugin to AngularCompilerPlugin for support angular 5.0.0

But there's no process about replacement or removement of moduleId in AngularCompilerPlugin.

(check the code as follows)

.then(() => _removeModuleId(refactor))

My AngularCompilerPlugin option is as follows

new AngularCompilerPlugin ({
    tsConfigPath: rootDir + '/tsconfig.json',
    entryModule: contentDir + '/scripts/app/app.module#AppModule',
    skipCodeGeneration: true
})

Thank you.

@KennethanCeyer
Copy link

I will put a comment with my personal account to check the progress of the issue.

@mlakmal
Copy link

mlakmal commented Nov 2, 2017

having same issue. we are using external libs as well as internal code that contain moduleId with relative template paths. and its breaking the app after built from new ngtool/webpack aot compiler

@filipesilva filipesilva added needs: investigation Requires some digging to determine if action is needed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Nov 2, 2017
@kenneth-igaw
Copy link
Author

+Notice
This issue is related #3576

@hansl hansl removed their assignment Feb 6, 2018
vikerman pushed a commit that referenced this issue Nov 8, 2018
…orators (#12503)

At the moment we are processing all property assignments in object literals irrespective if they are in a decorator or not. With this change we will process only property assignments found under in a component decorator.

Fixes #12488, Fixes #6007, Fixes: #6498 and Fixes: #8295
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
ikjelle pushed a commit to ikjelle/angular-cli that referenced this issue Mar 26, 2024
…orators (angular#12503)

At the moment we are processing all property assignments in object literals irrespective if they are in a decorator or not. With this change we will process only property assignments found under in a component decorator.

Fixes angular#12488, Fixes angular#6007, Fixes: angular#6498 and Fixes: angular#8295
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: investigation Requires some digging to determine if action is needed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
5 participants