-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng xi18n doesn't report typescript errors #8065
Comments
This one is quite painful for me :) Both serve and builds work, but for some reason xi18n doesn't output any errors or files and I had no idea why. In the end, it seemed to be caused by this which used to be reported: <div i18n>
<span i18n>Something</span>
</div> |
I thought that you had fixed that one @filipesilva ? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Versions.
Repro steps.
Create a new app with the cli 1.5.0-rc.0 but skip install. Update Angular dependencies to 5.0.0-rc.2, but don't update typescript (keep ~2.3.3).
Update your component to add a
i18n
attribute on some text. For example:<h1 i18n>Welcome to {{title}}!</h1>
.Add the following command to your package.json file:
"extract": "ng xi18n -f xlf -l en --of messages.xlf -op src/i18n"
and start it withnpm run extract
.The app is compiled and... nothing happens. The translations are not extracted.
The log given by the failure.
There is no log and that is the problem. The actual error is:
But it is not reported. If you go to this line:
angular-cli/packages/@angular/cli/tasks/extract-i18n.ts
Line 39 in db9c55c
err
isnull
, but if you log the stats object you will see the errors.Also the
.catch
method line 53 is called buterr
isundefined
so nothing happens (I'm not sure if it is related).Desired functionality.
It should log the error to the console and fail the extraction instead of looking like everything worked.
The text was updated successfully, but these errors were encountered: