Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barrel exports should be alphabetized #582

Closed
johnpapa opened this issue May 1, 2016 · 2 comments · Fixed by #749
Closed

Barrel exports should be alphabetized #582

johnpapa opened this issue May 1, 2016 · 2 comments · Fixed by #749

Comments

@johnpapa
Copy link
Contributor

johnpapa commented May 1, 2016

Minor nit

can we alphabetize them?

export * from './entity.service';
export * from './exception.service';
export * from './init-caps.pipe';
export * from './message.service';
export * from './config';
export * from './toast';
export * from './toast/toast.service';
export * from './spinner';
export * from './spinner/spinner.service';
export * from './speaker.service';
export * from './speaker.model';
export * from './nav';
export * from './modal';
export * from './modal/modal.service';
export * from './filter-text';
export * from './filter-text/filter-text.service';

cc @Brocco

@Brocco Brocco self-assigned this May 1, 2016
phillipgreenii added a commit to phillipgreenii/angular-cli that referenced this issue May 13, 2016
phillipgreenii added a commit to phillipgreenii/angular-cli that referenced this issue May 13, 2016
phillipgreenii added a commit to phillipgreenii/angular-cli that referenced this issue May 14, 2016
phillipgreenii added a commit to phillipgreenii/angular-cli that referenced this issue May 28, 2016
@Blasz
Copy link

Blasz commented Jun 24, 2016

Won't specific barrel ordering be required when any of the exports depend on each other to prevent circular dependencies? Making them alphabetised may break this. angular/angular#9334

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants