Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static JS assets not copying #540

Closed
stephenthedev opened this issue Apr 26, 2016 · 11 comments · Fixed by #1129
Closed

Static JS assets not copying #540

stephenthedev opened this issue Apr 26, 2016 · 11 comments · Fixed by #1129
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@stephenthedev
Copy link

Hello Angular-Cli Folks!

I am having trouble getting static JS files (like jquery components for a static page) to copy over the dist folder in version 0.0.34.

Placing the JS folder in the client, or app/assets does nothing, and they are just skipped. Other non JS files are not however in these areas.

Let me know what is the right approach to have static JS files.

@jkuri
Copy link
Contributor

jkuri commented Apr 26, 2016

Hi @raghunat. Everything from the public/ directory gets copied as is to the dist/.

@jkuri jkuri closed this as completed Apr 28, 2016
@JonGaribay
Copy link

I'm not finding this to be the case when the -prod flag is used. It seems like whenever a production build is done, js files inside of public are not included.

@BenevidesLecontes
Copy link

@JonGaribay I'm having this issue too. I'm using bower files on public folder, but js files are not included on dist folder when use ng serve -prod, only the .map are included

@stephenthedev
Copy link
Author

@jkuri this is still happening. Public JS files are not copied when using the -prod flag

@briananderson1222
Copy link

briananderson1222 commented May 27, 2016

Not sure this is exactly the same but I load an HttpInterceptor from the main.ts that doesn't seem to be getting copied when using the build for production environments.

// main.ts
import {HttpInterceptor} from './app/shared/http/http.interceptor';

Everything builds fine but when loading the web page I get:
zone.js:101 GET http://localhost:4200/app/shared/http/http.interceptor.js 404 (Not Found)

I have tried commenting out this line and am now experiencing no build or console issues.. but the application does not load..

@fadeojo
Copy link

fadeojo commented Jun 4, 2016

@jkuri I am also seeing this. The javascript files in my public folder are not getting copied over.

@steveblue
Copy link

steveblue commented Jun 5, 2016

@jkuri this issue should be reopened. I can replicate on latest master with -prod flag set, nothing in the vendor folder is getting copied to dist.

@filipesilva filipesilva reopened this Jun 7, 2016
@filipesilva filipesilva added type: bug/fix command: build P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 7, 2016
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jun 18, 2016
@filipesilva
Copy link
Contributor

I added in #1129 that should address this issue. If it's accepted, it should be in the next beta.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jun 18, 2016
@moxival
Copy link

moxival commented Jul 11, 2016

We are having the same problem. Any idea when this will be fixed?

@Splaktar
Copy link
Member

I agree. This seems like an obvious fix and there have been no comments in the PR about there being a problem. Why has this sat for almost a month without getting merged? It missed beta.9.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants