-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng test fails when using ngrx and module.Id #5143
Comments
Hi @alvipeo, I tried reproducing this but couldn't. Could you give me a repository or some code example? What does your Component looks like? |
@hansl thanks for looking into this. Can I give you the link to the private repo? I have it in VSTS. I will need your MS account. Or I can zip it and give a private link (via email). Sorry, can't make that repo public. |
I'm getting the same error, without ngrx in my project (although with angular-material):
and
I'm also getting this:
Not certain if it's a related issue, but same module build error at least (I'm on rc.1) Wrote up a quick repo that reproduces the error for me. ng -v:
Hope this helps :) (// cc @hansl) |
Technically that program should always be the valid one, and is needed in some cases (e.g. diagnostics). Adding parent nodes get rid of the getChildAt error that happens, because the prop.parent is not set. The issue happened because people are using "files": ["main.ts"] or something similar, and when we load another file than main we dont set the parent nodes. Fixes angular#5143 Fixes angular#4817
Technically that program should always be the valid one, and is needed in some cases (e.g. diagnostics). Adding parent nodes get rid of the getChildAt error that happens, because the prop.parent is not set. The issue happened because people are using "files": ["main.ts"] or something similar, and when we load another file than main we dont set the parent nodes. Fixes angular#5143 Fixes angular#4817
Technically that program should always be the valid one, and is needed in some cases (e.g. diagnostics). Adding parent nodes get rid of the getChildAt error that happens, because the prop.parent is not set. The issue happened because people are using "files": ["main.ts"] or something similar, and when we load another file than main we dont set the parent nodes. Fixes angular#5143 Fixes angular#4817
Technically that program should always be the valid one, and is needed in some cases (e.g. diagnostics). Adding parent nodes get rid of the getChildAt error that happens, because the prop.parent is not set. The issue happened because people are using "files": ["main.ts"] or something similar, and when we load another file than main we dont set the parent nodes. Fixes #5143 Fixes #4817
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Win 10 x64
Versions.
RC.0
Repro steps.
use moduleId in @component() decorator in a project where @NxRx is used. Run 'ng test' -> get weird errors.
The log given by the failure.
Module build failed: TypeError: Cannot read property 'getChildAt' of undefined
at refactor.findAstNodes.filter.forEach (E:\Documents\Visual Studio 2015\Projects\prj\node_modules@ngtools\webpack\src\loader.js:221:54)
at Array.forEach (native)
at _removeModuleId (E:\Documents\Visual Studio 2015\Projects\prj\node_modules@ngtools\webpack\src\loader.js:215:10)
at Promise.resolve.then.then (E:\Documents\Visual Studio 2015\Projects\prj\node_modules@ngtools\webpack\src\loader.js:298:33)
The text was updated successfully, but these errors were encountered: