feat(e2e): use protractor api #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
use-protractor-api
branch
3 times, most recently
from
e8b2066 to
ab02a2e
Compare
|
@vikerman Please review this from the protractor side :) |
filipesilva
force-pushed
the
use-protractor-api
branch
2 times, most recently
from
658f964 to
6120c0f
Compare
vikerman
reviewed
Feb 9, 2017
| if (e2eTaskOptions.webdriverUpdate) { | ||
| // webdriver-manager can only be accessed via a deep import from within | ||
| // protractor/node_modules. A double deep import if you will. | ||
| const webdriverUpdate = requireProjectModule(projectRoot, |
There was a problem hiding this comment.
This should be ok for now - This interface is not changing for now. Will see how we can make this public for the future.
vikerman
approved these changes
Feb 9, 2017
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
filipesilva
force-pushed
the
use-protractor-api
branch
from
6120c0f to
48f8344
Compare
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses existing Protractor API to run it directly instead of using
npm run e2e.Also adds support for the following flags:
--serve,--config,--specs,--element-explorer,--webdriver-update.Fix #4256
Fix #4478
Close #1054
BREAKING CHANGE:
ng e2eno longer needsng serveto be running.