-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flakey-ness in e2e tests with ng serve
#4478
Comments
My usual solution to this is to not use Something like this (in terms of npm scripts):
I recognize the convenience of not having to manage processes to run e2e tests though. Maybe as part of #4256 a new flag could be introduced that would manage this on the CLI side. Hypothetically something like |
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
Uses existing Protractor API to run it directly instead of using `npm run e2e`. Also adds support for the following flags: `--serve`, `--config`, `--specs`, `--element-explorer`, `--webdriver-update`. Fix angular#4256 Fix angular#4478 BREAKING CHANGE: `ng e2e` no longer needs `ng serve` to be running.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Versions.
Mention any other details that might be useful.
In order to run e2e tests, one has to run
ng serve
andng e2e
in parallel. Now, becauseng serve
does some preprocessing before serving (webpack build), it seems that protractor may timeout before the Angular app is served. This leads to flakey-ness on CI.We (think we) have run into this here (which is a cli-generated app), but this issue will probably affect all projects using the cli. I think @filipesilva was running into something similar recently. We have tried several things, from increasing timeouts to other hacks, but a more robust solution is necessary.
Something like this helper might be useful for users or maybe another way is more appropriate. But it sounds like something that would benefit most users and it would be nice if the cli provided an easy way out.
cc @IgorMinar
The text was updated successfully, but these errors were encountered: