-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng lint doesn't provide lines anymore #3993
Comments
I'm getting errors correctly. This is what I did to test: On a new project, add
What kind of error did you add? Maybe it's a different problem. Can you also do
|
I had that problem also. I think, it is because the tslint.json includes invalid configuration. I assume, you must have upgraded tslint previously and some of the configuration params became invalid. |
@zsfarkas that makes sense, inside |
|
I see this behavior when there are TypeScript compile errors. Running |
I've the same problem just getting the lines below. The thing I did a fresh ng init on my project with 25.5 as version and took the tsconfig clean from 25.5. @kalahari
|
Same problem for me. With the type-check option, I get this error:
Edit: |
I am having a similar issue, with
And with
Strangely, with If I remove I am running on the following env:
|
The project where I tried that is here : https://gitlab.com/victornoel/petals-cockpit/tree/front/refactor-whole-app It might help to debug. If you want to reproduce, just clone the project, checkout front/refactor-whole-app and in frontend/package.json update the lint to one we now have in beta-25.5 (I removed it so the lint can still work). |
I found that problem too in 1.0.0-beta.26. There were some lint errors in e2e tests but ng lint did not show any of them just saying "Lint errors found...". Then I run npm run lint and it listed all the e2e spec files where errors have been found. |
Same problem
|
Yup, i can confirm i have the same problem.
Removing |
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the new `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "<%= sourceDir %>/**/*.ts", "project": "<%= sourceDir %>/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the new `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the updated `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the updated `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
Closes #867, #3993 BREAKING CHANGE: In order to use the updated `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
Fixed by #4248 |
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the updated `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions.
Repro steps.
ng lint
The log given by the failure.
Notice that there's an error but not lines in the output.
Hard to correct :)
Mention any other details that might be useful.
If I go back to lint I had before in my package.json, it's working just fine :
"lint": "tslint \"src/**/*.ts\"
When I updated to beta-25.5 it was replaced by
"lint": "tslint \"src/**/*.ts\" --project src/tsconfig.json --type-check && tslint \"e2e/**/*.ts\" --project e2e/tsconfig.json --type-check",
The text was updated successfully, but these errors were encountered: