Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Allow specification of module when generating #3806

Closed
Brocco opened this issue Dec 31, 2016 · 2 comments · Fixed by #3811
Closed

Feature: Allow specification of module when generating #3806

Brocco opened this issue Dec 31, 2016 · 2 comments · Fixed by #3811
Assignees
@Brocco
Labels
feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@Brocco
Copy link
Contributor

Brocco commented Dec 31, 2016

Currently when generating components, pipes and directives they are auto imported and declared in the closest NgModule.

Add a flag to these generations to allow for specification of where they should be generated.

This flag will be a string which will be a relative path to the module file.
@Brocco
Copy link
Contributor Author

Brocco commented Dec 31, 2016

This feature could be implemented in conjunction with #3778

@Brocco Brocco self-assigned this Dec 31, 2016
@Brocco Brocco mentioned this issue Dec 31, 2016
Closed
@Brocco Brocco added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion feature Issue that requests a new feature labels Dec 31, 2016
Brocco added a commit to Brocco/angular-cli that referenced this issue Dec 31, 2016
@Brocco
feat(generate): add ability to specify module for import
67722ea 
Closes angular#3806
@Brocco Brocco mentioned this issue Dec 31, 2016
Merged
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 1, 2017
@Brocco
feat(generate): add ability to specify module for import
a4ed84e 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 1, 2017
@Brocco
feat(generate): add ability to specify module for import
dd4933e 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 1, 2017
@Brocco
feat(generate): add ability to specify module for import
b1d90a2 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 1, 2017
@Brocco
feat(generate): add ability to specify module for import
2a25b66 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 1, 2017
@Brocco
feat(generate): add ability to specify module for import
21334bb 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 2, 2017
@Brocco
feat(generate): add ability to specify module for import
4aab8d8 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 2, 2017
@Brocco
feat(generate): add ability to specify module for import
c086df9 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 2, 2017
@Brocco
feat(generate): add ability to specify module for import
463c501 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 2, 2017
@Brocco
feat(generate): add ability to specify module for import
4a0aa4c 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 2, 2017
@Brocco
feat(generate): add ability to specify module for import
81fce00 
Closes angular#3806
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 2, 2017
@Brocco
feat(generate): add ability to specify module for import
a76fa63 
Closes angular#3806
@baruchvlz baruchvlz mentioned this issue Jan 2, 2017
Closed
Brocco added a commit to Brocco/angular-cli that referenced this issue Jan 3, 2017
@Brocco
feat(generate): add ability to specify module for import
7f369c9 
Closes angular#3806
filipesilva pushed a commit that referenced this issue Jan 3, 2017
@Brocco @filipesilva
feat(generate): add ability to specify module for import (#3811)
e2b051f 
Closes #3806
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@Brocco @MRHarrison
feat(generate): add ability to specify module for import (angular#3811)
99c9116 
Closes angular#3806
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brocco Brocco

Labels
feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(generate): add ability to specify module for import Brocco/angular-cli
1 participant
@Brocco