Fix(version): allow Angular major version other than 2 #3729
Conversation
| @@ -105,11 +105,11 @@ export class Version { | |||
| if (v.isLocal()) { | |||
| console.warn(yellow('Using a local version of angular. Proceeding with care...')); | |||
| } else { | |||
| if (v.major != 2 || ((v.minor == 3 && v.patch == 0) || v.minor < 3)) { | |||
| if (v.major < 2 || ((v.minor == 3 && v.patch == 0) || v.minor < 3)) { | |||
There was a problem hiding this comment.
This would break at version 3.3.0!?
There was a problem hiding this comment.
But there will be no Angular 3, right? But you brought up a good point because this will fail in ng 4.3.0. I'll fix it.
There was a problem hiding this comment.
@abdulhaq-e are you still working on this? 4.3.0 would not work.
There was a problem hiding this comment.
I just updated it, should work now.
|
Something to note is that this is probably intentionally strict to ensure that a private API is available. |
|
The error message is implying a much more trivial reason... |
|
Generally, implementation details are not exposed to the end user. |
abdulhaq-e
force-pushed
the
fix_version_check
branch
from
038378a to
016a868
Compare
abdulhaq-e
force-pushed
the
fix_version_check
branch
from
016a868 to
acd8464
Compare
|
Sorry for stepping in lately. Please see this PR #3785 |
|
I agree, I thought about using it but because I am unfamiliar with angular-cli code I didn't want to add another library to the dependencies. It turns out it's already used! I'll close this :) . |
|
I created a small fork for very impatient people: It includes the required fix and has an updated |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I am not sure if other changes are required, but using angular v4 was blocked because of this strict version check. See this issue: #3720