-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify AoT compilation by ignoring genDir #2849
Comments
I'm going to remove the |
hansl
added a commit
to hansl/angular-cli
that referenced
this issue
Oct 25, 2016
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc. Fixes angular#2849.
hansl
added a commit
to hansl/angular-cli
that referenced
this issue
Oct 25, 2016
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc. Fixes angular#2849.
hansl
added a commit
to hansl/angular-cli
that referenced
this issue
Oct 27, 2016
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc. Fixes angular#2849.
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this issue
Feb 9, 2017
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc. Fixes angular#2849. Close angular#2876
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Given the AoT plugin no longer writes generated code to disk, allowing a developer to set the genDir for code generation adds a huge amount of complexity to lazy module resolution.
We should simply assume that the generated code ends up in the (virtual) filesystem as a sibling to the original file, and thus resolving for ngfactory code should require simply appending
.ngfactory
to the path.The text was updated successfully, but these errors were encountered: