-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PortFinder crashes with unused adapter #2769
Comments
Should have mentioned, it fails when specifying the host and port too, I've tried combinations of ports and different hosts like 127.0.0.1, localhost, and my local network ip:
|
I see there is an issue on ember-cli for what seems to be the same problem. I don't know the best place to mention it, but I don't think portfinder should be used if you specify the ports, and if it does throw an error then a warning should probably be displayed and the specified or default port should be attempted... |
Per a comment, pinning PortFinder at 1.0.7 seems to work around the issue. Totally understand if someone wants to close this issue, keep the same strategy of using portfinder even if ports are specified, and wait for upstream fixes...
|
Portfinder 1.0.9 has been published to npm. It simply reverts 1.0.8, so the issue is fixed now. Sorry about that folks |
This PR explicitely adds portfinder as a dependency. We're using portfinder in the serve command but getting it transitively as a ember-cli dependency. Fix angular#2769
This PR explicitely adds portfinder as a dependency. We're using portfinder in the serve command but getting it transitively as a ember-cli dependency. Fix angular#2755 Fix angular#2769
This PR explicitely adds portfinder as a dependency. We're using portfinder in the serve command but getting it transitively as a ember-cli dependency. Fix angular#2755 Fix angular#2769
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Versions.
Repro steps.
The log given by the failure.
Mention any other details that might be useful.
The fe80::xxxxx is a currently disabled or unavailable adapter. PortFinder.getPort doesn't appear to use the host specified and checks for the port on all adapters, and throws an uncaught exception. To be able to start my app I had to edit
node_modules/angular-cli/commands/serve.js
and change _checkExpressPort and _ autoFindLiveReloadPort to not use getPort:The text was updated successfully, but these errors were encountered: