Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng doc <keyword> update #2731

Closed
thiryj opened this issue Oct 16, 2016 · 4 comments
Closed

ng doc <keyword> update #2731

thiryj opened this issue Oct 16, 2016 · 4 comments
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@thiryj
Copy link

thiryj commented Oct 16, 2016

Please provide us with the following information:

OS?

Windows 10 ver 1607

Versions.

angular-cli: 1.0.0-beta.17
node: 4.5.0
os: win32 x64

Repro steps.

from terminal type: 'ng doc keyword'

The log given by the failure.

result is browser (chrome Version 53.0.2785.143 m) does not display the desired doc page referenced by 'keyword'. instead browser displays generic API reference page.

Mention any other details that might be useful.

Proposed fix: change line 6 of packages/angular-cli/tasks/doc.ts
from (broken)
const searchUrl = https://angular.io/docs/ts/latest/api/#!?apiFilter=${keyword};
to (working)
const searchUrl = https://angular.io/docs/ts/latest/api/#!?apiFilter=${keyword}&query=${keyword};


Thanks! We'll be in touch soon.

@filipesilva
Copy link
Contributor

Good catch! Would you be willing to submit a PR to fix it? I'd review it.

@filipesilva filipesilva added type: bug/fix P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Oct 17, 2016
@thiryj
Copy link
Author

thiryj commented Oct 18, 2016

Ok – will give it a shot.

From: Filipe Silva [mailto:[email protected]]
Sent: Monday, October 17, 2016 5:43 PM
To: angular/angular-cli [email protected]
Cc: John Thiry [email protected]; Author [email protected]
Subject: Re: [angular/angular-cli] ng doc update (#2731)

Good catch! Would you be willing to submit a PR to fix it? I'd review it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/2731#issuecomment-254343321, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIJwNXcmxU1CG4Vf4mnY0O7XuCmozqdlks5q0-v8gaJpZM4KYAyu.

@filipesilva
Copy link
Contributor

Fixed in #3383

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants