-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng doc <keyword> update #2731
Comments
Good catch! Would you be willing to submit a PR to fix it? I'd review it. |
Ok – will give it a shot. From: Filipe Silva [mailto:[email protected]] Good catch! Would you be willing to submit a PR to fix it? I'd review it. — |
Fixed in #3383 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
OS?
Windows 10 ver 1607
Versions.
angular-cli: 1.0.0-beta.17
node: 4.5.0
os: win32 x64
Repro steps.
from terminal type: 'ng doc keyword'
The log given by the failure.
result is browser (chrome Version 53.0.2785.143 m) does not display the desired doc page referenced by 'keyword'. instead browser displays generic API reference page.
Mention any other details that might be useful.
Proposed fix: change line 6 of packages/angular-cli/tasks/doc.ts
from (broken)
const searchUrl =
https://angular.io/docs/ts/latest/api/#!?apiFilter=${keyword}
;to (working)
const searchUrl =
https://angular.io/docs/ts/latest/api/#!?apiFilter=${keyword}&query=${keyword}
;The text was updated successfully, but these errors were encountered: