Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng e2e and ng lint have to hit Enter twice to go on #26724

Closed
1 task
doggy8088 opened this issue Dec 21, 2023 · 5 comments · Fixed by #26725
Closed
1 task

ng e2e and ng lint have to hit Enter twice to go on #26724

doggy8088 opened this issue Dec 21, 2023 · 5 comments · Fixed by #26725
Assignees
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix

Comments

@doggy8088
Copy link
Contributor

doggy8088 commented Dec 21, 2023

Command

e2e

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Please watch the video I prepared. YouTube: https://youtu.be/OMq-22_fsgI

Minimal Reproduction

ng new demo1 --ssr=false --style=css
ng e2e

Exception or Error

No response

Your Environment

Angular CLI: 17.0.7
Node: 18.16.0
Package Manager: npm 9.5.1
OS: win32 x64

Angular: 17.0.7
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.7
@angular-devkit/build-angular   17.0.7
@angular-devkit/core            17.0.7
@angular-devkit/schematics      17.0.7
@schematics/angular             17.0.7
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.2

Anything else relevant?

ng lint have the same issue as well. When seeing Would you like to proceed?, I have to hit Enter twice to proceed.

@doggy8088 doggy8088 changed the title ng e2e has a UX issue ng e2e have to hit Enter twice to go on Dec 21, 2023
@doggy8088 doggy8088 changed the title ng e2e have to hit Enter twice to go on ng e2e and ng lint have to hit Enter twice to go on Dec 21, 2023
@alan-agius4
Copy link
Collaborator

Hi @doggy8088, I am unable to replicate this on both Linux and Windows. Can you try using a different command line tool? Worth mentioning that we do not have special logic for this sort of prompt and we use Inquirer.js directly hence if there is a bug it's unlikely that it is actionable from our end.

@alan-agius4 alan-agius4 added the needs: more info Reporter must clarify the issue label Dec 21, 2023
@doggy8088
Copy link
Contributor Author

doggy8088 commented Dec 21, 2023

I tried Command Prompt (cmd.exe). It's the same issue.

I recorded another video for this time: https://youtu.be/f2Qp9nb4klA

@doggy8088
Copy link
Contributor Author

I just tried @inquirer/prompts in my cmd.exe or pwsh.exe. It works fine. Only ng e2e have this issue.

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @angular/cli and removed needs: more info Reporter must clarify the issue labels Dec 21, 2023
@alan-agius4 alan-agius4 self-assigned this Dec 21, 2023
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 21, 2023
…r twice to go on on Windows

This fixes an issue where prompts in nested child processes on Windows require multiple keystrokes to proceed.

Closes angular#26724
@alan-agius4
Copy link
Collaborator

@doggy8088, managed to replicate on Windows with cmd.exe and I have a fix in flight for this in #26725.

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 21, 2023
…r twice to proceed on Windows

This fixes an issue where prompts in nested child processes on Windows require multiple keystrokes to proceed.

Closes angular#26724
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Dec 21, 2023
…r twice to proceed on Windows

This fixes an issue where prompts in nested child processes on Windows require multiple keystrokes to proceed.

Closes angular#26724
alan-agius4 added a commit that referenced this issue Dec 21, 2023
…r twice to proceed on Windows

This fixes an issue where prompts in nested child processes on Windows require multiple keystrokes to proceed.

Closes #26724
alan-agius4 added a commit that referenced this issue Dec 21, 2023
…r twice to proceed on Windows

This fixes an issue where prompts in nested child processes on Windows require multiple keystrokes to proceed.

Closes #26724

(cherry picked from commit a391b5f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
2 participants