-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: src/app/shared add documentation comments to index.ts #2572
Comments
@Brocco what do you think about adding comment docs to Regarding |
The idea of |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions.
angular-cli: 1.0.0-beta.16
node: 6.3.1
os: linux x64
Repro steps.
Create project with
ng new
Needed Documentation
angular-cli projects have a shared directory with this file src/app/shared/index.ts
I haven't read through all of the new NgModule docs on angular.io, so I wasn't sure what this was for.
Please add a comment to this file that links to angular.io:
https://angular.io/docs/ts/latest/guide/ngmodule.html#!#shared-module
Also, maybe give a few example ng commands. (angular-cli/tests/acceptance has a couple examples)
ng generate module shared/my-module
ng generate class shared/my-class
Questions
Should the developer modify shared/index.ts?
Do they need to add
export * from './my-module'
as in src/app/index.ts?Also, I noticed angular-cli/tests/e2e/tests/build/ts-paths.ts modifies tsconfig.json so that you can
import '@shared/my-module;
Should this be added to tsconfig.json by default or should it be documented somewhere?
shared/index.ts
The text was updated successfully, but these errors were encountered: