Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable Odd numbered Node.js version warning #24104

Closed
hkjeffchan opened this issue Oct 19, 2022 · 2 comments · Fixed by #24112
Closed

disable Odd numbered Node.js version warning #24104

hkjeffchan opened this issue Oct 19, 2022 · 2 comments · Fixed by #24112
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix

Comments

@hkjeffchan
Copy link

Command

config

Description

The following will be shown for odd numbered node.js env

Node.js version v19.0.0 detected.
Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/releases/.

Not a problem most of the time except when you appended source <(ng completion script) to your shell init script. The warning broke the source action.

Describe the solution you'd like

allow flag to disable this warning

Describe alternatives you've considered

No response
@alan-agius4
Copy link
Collaborator

We should disable the warning in this case.

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @angular/cli labels Oct 20, 2022
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Oct 21, 2022
@alan-agius4
fix(@angular/cli): skip node.js compatibility checks when running com…
c1b3a1d 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes angular#24104
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Oct 21, 2022
@alan-agius4
fix(@angular/cli): skip node.js compatibility checks when running com…
1d89773 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes angular#24104
@alan-agius4 alan-agius4 mentioned this issue Oct 21, 2022
Merged
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Oct 21, 2022
@alan-agius4
fix(@angular/cli): skip node.js compatibility checks when running com…
96e3982 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes angular#24104
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Oct 24, 2022
@alan-agius4
fix(@angular/cli): skip node.js compatibility checks when running com…
0582f59 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes angular#24104
dgp1130 pushed a commit that referenced this issue Oct 24, 2022
@alan-agius4 @dgp1130
fix(@angular/cli): skip node.js compatibility checks when running com…
1e4dbfd 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes #24104
dgp1130 pushed a commit that referenced this issue Oct 24, 2022
@alan-agius4 @dgp1130
fix(@angular/cli): skip node.js compatibility checks when running com…
952fe7f 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes #24104

(cherry picked from commit 1e4dbfd)
dgp1130 pushed a commit that referenced this issue Oct 24, 2022
@alan-agius4 @dgp1130
fix(@angular/cli): skip node.js compatibility checks when running com…
02a3d7b 
…pletion

A warning at this stage could cause a broken source action (`source <(ng completion script)`) when in the shell init script.

Closes #24104

(cherry picked from commit 1e4dbfd)
@richardlau richardlau mentioned this issue Oct 26, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): skip node.js compatibility checks when running completion alan-agius4/angular-cli
2 participants
@hkjeffchan @alan-agius4