Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'notifications' of undefined #214

Closed
danwkennedy opened this issue Feb 17, 2016 · 8 comments
Closed

Cannot read property 'notifications' of undefined #214

danwkennedy opened this issue Feb 17, 2016 · 8 comments

Comments

@danwkennedy
Copy link

If the package.json file doesn't have an "angular-cli" field, calls to ng build will fail with the following error:

TypeError: [DiffingTSCompiler]: Cannot read property 'notifications' of undefined
    at DiffingTSCompiler.showNotification (..../node_modules/angular-cli/lib/broccoli/broccoli-typescript.js:196:38)
@filipesilva
Copy link
Contributor

I believe this should be "fixed" in the latest master. By fixed though, I mean the notification functionality should be inadvertently gone and thus the notification check does not happen anymore.

@hansl can you chime in? I'm following info from #134 (comment) together with #206

@danwkennedy
Copy link
Author

I found this on the latest master as of yesterday morning. I can try again on a later commit in a bit. The work around obviously is to add that option in package so it hasn't blocked me or anything

@filipesilva
Copy link
Contributor

#206 happened 16h ago, I think that is when it changed.

@danwkennedy
Copy link
Author

Looks like it's fixed in 0.0.20 👍

@hansl
Copy link
Contributor

hansl commented Feb 18, 2016

@filipesilva: Yes, it was fixed. This is a non-issue for now :)

@filipesilva
Copy link
Contributor

@hansl If it is indeed removed, then the rest of the changes introduced in the original PR should also be removed.

@hansl
Copy link
Contributor

hansl commented Feb 18, 2016

Agreed. If you don't have time for that I can do it.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Feb 25, 2016
@filipesilva
chore(notifications): revert remaining files
961a50c 
In angular#214, the main notification functionality was removed
due to it being in a auto-generated file.

This PR removes the remainder code that was left in from angular#134.

The `angular-cli` property in generated `package.json` is left in
since that was the place agreed for further configuration.
@filipesilva filipesilva mentioned this issue Feb 25, 2016
Closed
clydin pushed a commit that referenced this issue Jun 5, 2018
@hansl @filipesilva
fix(@angular-devkit/build-optimizer): fix hoisted class declarations
7aec16f 
The problem is that hoisted classes dont have the same name, so we need to change
the regex, and to check the end of it for the class name.

Also added a test to verify this works (based on RxJS issue).

Also refactored the complex regex to make a bit more sense.

Fixes #214.
hansl added a commit that referenced this issue Jun 6, 2018
@hansl
fix(@angular-devkit/build-optimizer): fix hoisted class declarations
cd0d619 
The problem is that hoisted classes dont have the same name, so we need to change
the regex, and to check the end of it for the class name.

Also added a test to verify this works (based on RxJS issue).

Also refactored the complex regex to make a bit more sense.

Fixes #214.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danwkennedy @hansl @filipesilva