Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --nospec flag for services #2108

Closed
cburgdorf opened this issue Sep 14, 2016 · 4 comments · Fixed by #2382
Closed

Allow --nospec flag for services #2108

cburgdorf opened this issue Sep 14, 2016 · 4 comments · Fixed by #2382
Assignees
Labels
effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@cburgdorf
Copy link
Contributor

With a85a507 a --nospec option was introduced to generate components without tests.

In case there isn't a specific reason why this option shouldn't be valid for services as well, I propose to implement it for consistency.

//cc @PascalPrecht

@filipesilva filipesilva added this to the RC1 milestone Sep 21, 2016
@filipesilva filipesilva added effort1: easy (hours) command: generate P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Sep 21, 2016
@Brocco
Copy link
Contributor

Brocco commented Sep 22, 2016

I agree with this as well, but would also expand it to not just services, but also directives, pipes, classes.

@filipesilva
Copy link
Contributor

All for it myself.

@niklas-dahl
Copy link
Contributor

When adding the --nospec flag to all generate commands, wouldnt it make sense to add it to ng new aswell, just like it works with ng new sassy-project --style=sass?

ng new notests --nospec would then omit the generation of the e2e folder, karma.conf.js, protactor.conf.js, src/test.ts and src/app/app.component.spec.ts.

Additionally it could set a flag in the angular-cli.json so that all generatecommands know to not generate a spec file.

Could look like this:

"defaults": { "styleExt": "scss", "prefixInterfaces": false, "generateSpecs": false }

I know I am a terrible person for asking for this, but sometimes the test stuff just gets in the way.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
clydin pushed a commit to clydin/angular-cli that referenced this issue Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants