Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail on ERROR #2014

Closed
FallenRiteMonk opened this issue Sep 7, 2016 · 4 comments · Fixed by #2360
Closed

Build fail on ERROR #2014

FallenRiteMonk opened this issue Sep 7, 2016 · 4 comments · Fixed by #2360
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@FallenRiteMonk
Copy link
Contributor

Hy,

is it somehow possible to make a complete build fail if there is a error during the build?

My situation is the following: I have a CI setup that builds my project, wraps it into a docker and publishes it into a docker repo. If I then want to publish a the new version I use docker to pull the new image and run it. Recently I did exactly that to then discover that the app doesn't work. Looking trough the CI server logs I found out that the production build of angular-cli (beta webpack 8) had an ERROR message, but it did not fail the build. If it would have than no new docker image would have been published and I would have noticed before I published the new version.

Thanks and Greetings

@filipesilva
Copy link
Contributor

This is a bug actually. We should have a non-zero exit code for failed builds.

@filipesilva filipesilva added type: bug/fix command: build P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Sep 19, 2016
@filipesilva filipesilva self-assigned this Sep 19, 2016
@filipesilva filipesilva added this to the RC1 milestone Sep 19, 2016
@Blasz
Copy link

Blasz commented Sep 23, 2016

This would be great, I just experienced the same thing. Are there any workarounds we can do ourselves in the meantime?

@filipesilva
Copy link
Contributor

Seems related to webpack/webpack#708

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Sep 26, 2016
JJayet pushed a commit to JJayet/angular-cli that referenced this issue Oct 2, 2016
deebloo pushed a commit to deebloo/angular-cli that referenced this issue Oct 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants