externalSchematic doesn't work for globally installed nested dependencies

[bmayen]

🐞 Bug report

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Is this a regression?

Yes, this previously worked in v8

Description

Using "externalSchematic" on a collection defined in a dependency of a custom schematic, does not work when the custom schematic is installed globally. Globally installed npm packages are not flattened/deduped and the nested collection dependency is not found by "externalSchematic".

🔬 Minimal Reproduction

Running ng new -c schematic-1.

"schematic-1" is installed globally (npm i schematic-1 -g) and has an npm dependency on "schematic-2".

Under the global node_modules folder, "schematic-1" has a nested node_modules folder containing "schematic-2". If installed locally, npm will flatten the dependencies and "schematic-1" and "schematic-2" will be siblings, but a global install will nest "schematic-2" under "schematic-1".

"schematic-1" calls externalSchematic('schematic-2', 'ng-add', options), from ng new.

When installed globally, this fails with "Collection schematic-2 cannot be resolved" When installed locally, and dependencies are flatted, this succeeds.

🔥 Exception or Error

Collection schematic-2 cannot be resolved

🌍 Your Environment

Angular CLI: 9.1.9
Node: 10.21.0
OS: darwin x64

Angular:
...
Ivy Workspace:

Package Version

@angular-devkit/architect 0.901.9
@angular-devkit/core 9.1.9
@angular-devkit/schematics 9.1.9
@schematics/angular 9.1.9
@schematics/update 0.901.9
rxjs 6.5.4

[bmayen]

@alan-agius4, if someone can point me in the right direction, I can look into submitting a PR for this.

Where is the code that loads up the available collections under node_modules? Guessing the issue is that it doesn't look under the nested node_modules folder.

[bmayen]

With v11 on the horizon, are there any plans to address this regression? Or perhaps a suggestion for a better workaround? Currently, we have Schematics shared across multiple teams and external contractors and all are forced to install these Schematics locally in a parent folder whenever they need to run ng new.

[bmayen]

🎉 Thank you!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}