Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy + Support XTB load translations parser in v9 #16100

Closed
elvisbegovic opened this issue Nov 7, 2019 · 2 comments · Fixed by #16111
Closed

ivy + Support XTB load translations parser in v9 #16100

elvisbegovic opened this issue Nov 7, 2019 · 2 comments · Fixed by #16111
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature
Milestone

Comments

@elvisbegovic
Copy link
Contributor

🚀 Feature request

Command (mark with an x)

- [x] build
- [x] serve

Description

With IVY add support xtb_translation_parser

Describe the solution you'd like

I think ? in xtb_translation_parser.ts#L62 add:

xtb: new (await Promise.resolve().then(() => require(
// @ts-ignore
// tslint:disable-next-line:trailing-comma
'@angular/localize/src/tools/src/translate/translation_files/translation_parsers/xtb_translation_parser'))).XtbTranslationParser()

Anything else relevant?
Maybe at the moment xtb parser is not ready (@petebacondarwin ?) Because after hack locally and after my app build finish, I get warnings that almost all translations with interpolations are not translated:
xtb

A lot of them are duplicated

/cc @filipesilva

@filipesilva filipesilva added area: @angular-devkit/build-angular feature Issue that requests a new feature labels Nov 7, 2019
@ngbot ngbot bot added this to the Backlog milestone Nov 7, 2019
@filipesilva filipesilva modified the milestones: Backlog, v9-candidates Nov 7, 2019
@petebacondarwin
Copy link
Contributor

The i18Format needs to line up because we use a legacy mode if xliff that converts ids to xliff, which might be causing the misses...

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
@clydin clydin removed their assignment Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants