Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng generate library adds tsickle 0.36.0 dependency, incompatible to typescript 3.5 #15428

Closed
mscudlik opened this issue Aug 23, 2019 · 3 comments · Fixed by #15430
Closed

ng generate library adds tsickle 0.36.0 dependency, incompatible to typescript 3.5 #15428

mscudlik opened this issue Aug 23, 2019 · 3 comments · Fixed by #15430
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Milestone

Comments

@mscudlik
Copy link

🐞 Bug report

Description

@angular/[email protected]

ng new creates a project for an app, with a dependency to typescript 3.5
ng generate library adds a dependency to tsickle 0.36.0, which is incompatible to typescript 3.5.

as a consequence library providers cannot use typescript 3.5.
Removing the dependency to tsickle will brake ng build my-lib

So either tsickle should be made compatible to typescript 3.5, or the dependency to tsickle should be removed.

also see angular/tsickle#1048

🔬 Minimal Reproduction

ng new lib-test
cd lib-test
ng generate library my-lib

image

🔥 Exception or Error

If i remove tsickle manually, ng build will not run anymore:

image

🌍 Your Environment

$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 8.3.0
Node: 10.15.0
OS: win32 x64
Angular: 8.2.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.803.0
@angular-devkit/build-angular      0.803.0
@angular-devkit/build-ng-packagr   0.803.0
@angular-devkit/build-optimizer    0.803.0
@angular-devkit/build-webpack      0.803.0
@angular-devkit/core               8.3.0
@angular-devkit/schematics         8.3.0
@angular/cli                       8.3.0
@ngtools/webpack                   8.3.0
@schematics/angular                8.3.0
@schematics/update                 0.803.0
ng-packagr                         5.5.0
rxjs                               6.4.0
typescript                         3.5.3
webpack                            4.39.2
@alan-agius4
Copy link
Collaborator

@mscudlik, if you remove tsickle from your dependencies, you'd need to disable it's usage by setting annotateForClosureCompiler to false in tsconfig of your library.

@mscudlik
Copy link
Author

thanks a lot! :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity5: regression type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants