Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load es5 polyfills on ng test #14335

Closed
filipesilva opened this issue May 3, 2019 · 1 comment
Closed

Load es5 polyfills on ng test #14335

filipesilva opened this issue May 3, 2019 · 1 comment
Labels
Milestone

Comments

@filipesilva
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was: CLI 7

Description

The new polyfills-es5.js chunk is generated for ng test but never loaded.

🔬 Minimal Reproduction

The browser builder loads es5 polyfills by injecting them into the index html in

The karma builder has a two special index.html that it loads, and only the normal polyfills are listed

It should also be added to the list in

@clydin also mentioned that the karma loaded scripts (

<script type="text/javascript">
window.__karma__.loaded();
</script>
) might be problematic in conjunction with module scripts because they defer by default, and recommend having a module and nomodule version of the karma script.

🔥 Exception or Error

Unsure, probably missing native stuff on older browsers.

🌍 Your Environment

Anything else relevant?

@filipesilva filipesilva added area: @angular-devkit/build-angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix labels May 3, 2019
@ngbot ngbot bot added this to the Backlog milestone May 3, 2019
@filipesilva filipesilva modified the milestones: Backlog, 8.0 May 3, 2019
filipesilva added a commit to filipesilva/angular-cli that referenced this issue May 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant