Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older CLI versions didn't use target:es2015 so we need to update them #14321

Closed
StephenFluin opened this issue May 1, 2019 · 1 comment · Fixed by #14328
Closed

Older CLI versions didn't use target:es2015 so we need to update them #14321

StephenFluin opened this issue May 1, 2019 · 1 comment · Fixed by #14328

Comments

@StephenFluin
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

- [x] update

Is this a regression?

No

Description

If you used an older version of the CLI, you won't get the new differential loading benefits automatically because the CLI used to create new projects with target: es5 in the tsconfig.json.

Example: https://github.com/StephenFluin/angular-update-guide/blob/master/src/tsconfig.app.json

🔬 Minimal Reproduction

Take an old Angular app, run ng update @angular/cli@next @angular/core@next.

Run ng build --prod

🔥 Exception or Error

The built files will not support differential loading.

We should automatically check / fix this setting in an ng update schematic.

🌍 Your Environment


Angular CLI: 8.0.0-rc.2
Node: 12.1.0
OS: linux x64
Angular: 8.0.0-rc.2
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.0-rc.2
@angular-devkit/build-angular     0.800.0-rc.2
@angular-devkit/build-optimizer   0.800.0-rc.2
@angular-devkit/build-webpack     0.800.0-rc.2
@angular-devkit/core              8.0.0-rc.2
@angular-devkit/schematics        8.0.0-rc.2
@angular/cdk                      8.0.0-rc.0
@angular/material                 8.0.0-rc.0
@ngtools/webpack                  8.0.0-rc.2
@schematics/angular               8.0.0-rc.2
@schematics/update                0.800.0-rc.2
rxjs                              6.5.1
typescript                        3.4.5
webpack                           4.30.0

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants