Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentially loaded polyfill naming is confusing #13808

Closed
StephenFluin opened this issue Mar 3, 2019 · 1 comment · Fixed by #13809
Closed

Differentially loaded polyfill naming is confusing #13808

StephenFluin opened this issue Mar 3, 2019 · 1 comment · Fixed by #13809
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature freq1: low Only reported by a handful of users who observe it rarely severity1: confusing
Milestone

Comments

@StephenFluin
Copy link
Contributor

StephenFluin commented Mar 3, 2019

🚀 Feature request

Currently the differentially loaded polyfills are named something like this:
es2015-polyfills.93d33834f014c18240da.js
polyfills.13391cdb066748d88c83.js

These names are a little confusing because one might guess that the es2015 one is loaded by modern browsers, and the other one is loaded by legacy browsers, but this isn't what happens.

Today, the es2015-polyfills.js is loaded by browsers that DON'T support ES2015, and the file marked ES2015 is ACTUALLY ES5.

Proposals

I propose to instead name the legacy file based on what it contains in a way that makes it clearer by using an additional file extension. The modern one can stay the same this way.

polyfills.es5.js - Contains ES5 and is intended for older browsers
polyfills.js - Contains modern JS and is intended for modern browsers

clydin added a commit to clydin/angular-cli that referenced this issue Mar 3, 2019
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity1: confusing area: @angular-devkit/build-angular labels Mar 4, 2019
@ngbot ngbot bot modified the milestone: needsTriage Mar 4, 2019
@alan-agius4 alan-agius4 added the feature Issue that requests a new feature label Mar 4, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 4, 2019
hansl pushed a commit that referenced this issue Mar 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @angular-devkit/build-angular feature Issue that requests a new feature freq1: low Only reported by a handful of users who observe it rarely severity1: confusing
Projects
None yet
2 participants