-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) #12914
Comments
Currently you will need to execute |
I'm just running the command |
I'm having the same issue. I was able to get it to work by specifying the previous stable release: |
Oh hell, it worked for me. But is there any clue as to why? |
I'm not sure. The latest version was just published recently, so I'm guessing something isn't quite right with it. |
The latest version is targeted to be used with Version 7. |
No issue with bellow version. Update your cli.
Angular CLI: 7.0.5 |
I am using nx extensions cli v7 and angular cli 7.0.5 and ran into the same issue. |
Hi, the problem is no longer reproducable if you use the latest versions of the CLI and devkit packages.
|
@jakawell thanks so much.You rock. |
it should be fixed by updating your global angular cli to the last stable version |
"@angular-devkit/build-angular": "^0.10.5", |
As suggested by @clydin in angular/angular-cli#12914
The root cause here is that the @angular/pwa doesn't declare any peerDependency in the package.json config, so the npm client installs the latest one which doesn't seem to be compatible. To fix this we need to define a peerDep on the right version. To fix this for v6 developers, we might need to cut a version that is compatible with v6 and declares a peerDep on v6. |
|
on the cli because it's the cli that provides schematics and other stuff needed by @angular/pwa |
Makes sense. |
since cli and the framework are aligned on major versions, it should be
fine to pin pwa to just cli. no?
…On Wed, Nov 28, 2018 at 11:48 PM George Kalpakas ***@***.***> wrote:
Makes sense.
I just want to point out that some parts (such as the ngsw-config.json)
must be compatible with the @angular/service-worker version used. Maybe
we should move them to @angular/service-worker and have cli somehow get
them from there.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#12914 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6EB0KHPxEyQZ9wauacG9722gYHE9ks5uz5FVgaJpZM4YXdGF>
.
|
If we only change things related to the |
If you delete the node_modules folder it works fine. |
For my case I updated my angular CLI and then 'ng add @angular/pwa' is working fine. npm uninstall --save-dev angular-cli |
…encies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer dependencies that match the package versions supplied in the project's package.json Fixes angular#12914
…encies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer dependencies that match the package versions supplied in the project's package.json Fixes angular#12914
…encies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer dependencies that match the package versions supplied in the project's package.json Fixes #12914
Fixed via #13286 |
Nevermind, I updated my global cli but didn't noticed the project was using an older one installed locally. Bumped both it's working fine now. Sorry for the trouble. |
it seems to work, thnk u |
@jakawell muchas gracias. Me funciono (y) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Command (mark with an
x
)Versions
Angular CLI: 6.2.5
Node: 8.11.3
OS: win32 x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package Version
@angular-devkit/architect 0.8.5
@angular-devkit/build-angular 0.8.5
@angular-devkit/build-optimizer 0.8.5
@angular-devkit/build-webpack 0.8.5
@angular-devkit/core 0.8.5
@angular-devkit/schematics 0.8.5
@angular/cdk 6.4.7
@angular/cli 6.2.5
@angular/material 6.4.7
@angular/pwa 0.10.5
@ngtools/webpack 6.2.5
@schematics/angular 0.8.5
@schematics/update 0.8.5
rxjs 6.2.2
typescript 2.9.2
webpack 4.20.2
Repro steps
ng new pwademo
ng add @angular/material
ng build --prod
ng add @angular/pwa
The log given by the failure
Installing packages for tooling via npm.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
updated 1 package in 47.645s
Installed packages for tooling via npm.
Maximum call stack size exceeded
Desired functionality
The command doesnt add automatically PWA features to my Angular application such as manifest file or icons in assets folder or edit my index.html file with reference to manifest, only show me the error message
Maximum call stack size exceeded
Mention any other details that might be useful
The text was updated successfully, but these errors were encountered: