Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] schematics-cli doesn't set dryRun by default when using a local collection #12815

Closed
nweldev opened this issue Oct 31, 2018 · 1 comment · Fixed by #12820
Closed

Comments

@nweldev
Copy link
Contributor

nweldev commented Oct 31, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

repo: master

Repro steps

run on any collection
̀schematics .:`
this will create the files

The log given by the failure

Desired functionality

DryRun should be used by default when using a local collection.

Mention any other details that might be useful

This seems to be related to bb01cce, as argv.dryRun is now false instead of null by default. My guess would be that this is a problem with minimist, but I didn't investigated it that much. cc @alan-agius4

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants