Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng github-pages:deploy left the localproject on gh-pages branch #1259

Closed
xmlking opened this issue Jul 1, 2016 · 4 comments
Closed

ng github-pages:deploy left the localproject on gh-pages branch #1259

xmlking opened this issue Jul 1, 2016 · 4 comments
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix

Comments

@xmlking
Copy link

xmlking commented Jul 1, 2016

Please provide us with the following information:

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
OSX -  El Capitan
  1. Versions. Please run ng --version. If there's nothing outputted, please
    run in a Terminal:
    node --version
    And paste the result here.
(node:6824) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
angular-cli: 1.0.0-beta.8
node: 6.2.2
os: darwin x64
  1. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.

  2. The log given by the failure. Normally this include a stack trace and some
    more information.

  3. Mention any other details that might be useful.


After running ng github-pages:deploy --message "Optional commit message" command with no changes to code base, my local project is left on gh-pages branch. it should leave on master branch.

when it fails (it leaves in gp-pages branch)

image

when it works

image

@cre8
Copy link

cre8 commented Jul 1, 2016

You have to add the --user-page parameter to push it to the master

This command pushes the app to the master branch on the github repo instead of pushing to gh-pages, since user and organization pages require this.

@xmlking
Copy link
Author

xmlking commented Jul 1, 2016

@cre8 I don't want to push to master. I wanted to push to normal gp-pages branch. When it works , this commend brings back to master branch. But when it fails , it left my project directory at gp-pages branch.
My point is this angular-cli commend should not leave the code in gp-pages branch state whether it succeed or fail.

PS: I got email from github with title "[xmlking/parking] Page build failure". May be github had issues at that time.

@filipesilva filipesilva added type: bug/fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jul 4, 2016
@filipesilva
Copy link
Contributor

@xmlking you're right, the command shouldn't leave your repo in the wrong branch. Will investigate.

rolyatsats added a commit to rolyatsats/angular-cli that referenced this issue Dec 3, 2016
If github-pages:deploy fails due to 'No changes found' or fails pushing to git repo, it then attempts to checkout the initial branch.

Closes angular#3030
Closes angular#2663
Closes angular#1259
@hansl hansl closed this as completed in c5cd095 Dec 5, 2016
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
If github-pages:deploy fails due to 'No changes found' or fails pushing to git repo, it then attempts to checkout the initial branch.

Closes angular#3030
Closes angular#2663
Closes angular#1259
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

3 participants