Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6rc6 better output on ng -v command inside cli project when /node_modules not exist #10474

Closed
elvisbegovic opened this issue Apr 26, 2018 · 1 comment · Fixed by #18765
Closed

6rc6 better output on ng -v command inside cli project when /node_modules not exist #10474

elvisbegovic opened this issue Apr 26, 2018 · 1 comment · Fixed by #18765
Labels
area: @angular/cli P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix workaround1: obvious
Milestone
needsTriage

Comments

@elvisbegovic
Copy link
Contributor

Versions

Angular CLI: 6.0.0-rc.6
Node: 10.0.0
OS: win32 x64

Repro steps

  • ng new ap --skip-install
  • cd ap
  • ng -v

Observed behavior

cli version empty node_modules

Desired behavior

When we are inside new green cli project (without /node_modules folder), I think we should have same output from console ng -v like we have outside an cli project
image
@clydin clydin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 26, 2018
@ngbot ngbot bot modified the milestone: needsTriage May 26, 2020
@dgp1130 dgp1130 modified the milestones: needsTriage, Backlog May 26, 2020
@ngbot ngbot bot modified the milestones: Backlog, needsTriage May 26, 2020
@elvisbegovic elvisbegovic mentioned this issue Sep 11, 2020
Closed
2 tasks
clydin added a commit to clydin/angular-cli that referenced this issue Sep 11, 2020
@clydin
fix(@angular/cli): remove version command node module assumptions
6228068 
This change removes all direct usage of the `node_modules` directory from the version command.  This provides improved support for yarn PnP as well as prevents a crash when a workspace does not have a `node_modules` directory.

Fixes angular#10474
@clydin clydin mentioned this issue Sep 11, 2020
Merged
clydin added a commit that referenced this issue Sep 14, 2020
@clydin
fix(@angular/cli): remove version command node module assumptions
b6ea1ab 
This change removes all direct usage of the `node_modules` directory from the version command.  This provides improved support for yarn PnP as well as prevents a crash when a workspace does not have a `node_modules` directory.

Fixes #10474
clydin added a commit that referenced this issue Sep 16, 2020
@clydin
fix(@angular/cli): remove version command node module assumptions
227f30e 
This change removes all direct usage of the `node_modules` directory from the version command.  This provides improved support for yarn PnP as well as prevents a crash when a workspace does not have a `node_modules` directory.

Fixes #10474

(cherry picked from commit b6ea1ab)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @angular/cli P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix workaround1: obvious
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): remove version command node module assumptions clydin/angular-cli
3 participants
@elvisbegovic @dgp1130 @clydin