Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pin versions on ng update #10356

Closed
cyrilletuzi opened this issue Apr 16, 2018 · 2 comments
Closed

Do not pin versions on ng update #10356

cyrilletuzi opened this issue Apr 16, 2018 · 2 comments
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Milestone

Comments

@cyrilletuzi
Copy link
Contributor

cyrilletuzi commented Apr 16, 2018

Versions

cli 6.0.0-rc.4

Repro steps

From an Angular 5 project:

  • update the CLI to v6 and migrate
  • ng update @angular/core --next

Observed behavior

Pinned versions in package.json:

"@angular/compiler": "6.0.0-rc.5",
"@angular/core": "6.0.0-rc.5",
"typescript": "2.7.2"
...

Desired behavior

Keep semantic versionning in package.json:

"@angular/compiler": "^6.0.0-rc.5",
"@angular/core": "^6.0.0-rc.5",
"typescript": "~2.7.2"
...

Mention any other details that might be useful (optional)

Pinned versions mean we can't do anymore minor/patch updates of the whole project simply with npm update and goes against semver.

It's not the role of the CLI to pin the versions. It's the role of the package manager, and as Angular 6 and CLI 6 require Node >= 8.9 and npm >= 5.5, it means the job is already done in a proper way by the package-lock.json.

@filipesilva filipesilva added this to the v6.0.0 milestone Apr 16, 2018
@hansl
Copy link
Contributor

hansl commented Apr 23, 2018

I'm pretty sure this is a dupe as we've talked about it internally, but can't find the original issue so marking this as required.

@hansl hansl added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

No branches or pull requests

3 participants