-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not pin versions on ng update #10356
Labels
P5
The team acknowledges the request but does not plan to address it, it remains open for discussion
Milestone
Comments
I'm pretty sure this is a dupe as we've talked about it internally, but can't find the original issue so marking this as required. |
hansl
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
P5
The team acknowledges the request but does not plan to address it, it remains open for discussion
and removed
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
labels
Apr 23, 2018
filipesilva
added a commit
to angular/devkit
that referenced
this issue
May 10, 2018
hansl
pushed a commit
to angular/devkit
that referenced
this issue
May 10, 2018
hansl
pushed a commit
that referenced
this issue
Jun 6, 2018
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P5
The team acknowledges the request but does not plan to address it, it remains open for discussion
Versions
Repro steps
From an Angular 5 project:
ng update @angular/core --next
Observed behavior
Pinned versions in
package.json
:Desired behavior
Keep semantic versionning in
package.json
:Mention any other details that might be useful (optional)
Pinned versions mean we can't do anymore minor/patch updates of the whole project simply with
npm update
and goes against semver.It's not the role of the CLI to pin the versions. It's the role of the package manager, and as Angular 6 and CLI 6 require Node >= 8.9 and npm >= 5.5, it means the job is already done in a proper way by the
package-lock.json
.The text was updated successfully, but these errors were encountered: