Skip to content

Commit

Permalink
fix(@angular-devkit/build-angular): resolve postcss from build-angula…
Browse files Browse the repository at this point in the history
…r package

`postcss-loader` version 4.2.0 added an `implementation` option. Using the using will ensure that the correct postcss version is used.

More info: webpack-contrib/postcss-loader@deac978

Fixes #19839

(cherry picked from commit 5711e69)
  • Loading branch information
alan-agius4 authored and dgp1130 committed Jan 22, 2021
1 parent 50106ff commit f925099
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
"popper.js": "^1.14.1",
"postcss": "8.2.4",
"postcss-import": "14.0.0",
"postcss-loader": "4.1.0",
"postcss-loader": "4.2.0",
"prettier": "^2.0.0",
"protractor": "~7.0.0",
"puppeteer": "5.5.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"pnp-webpack-plugin": "1.6.4",
"postcss": "8.2.4",
"postcss-import": "14.0.0",
"postcss-loader": "4.1.0",
"postcss-loader": "4.2.0",
"raw-loader": "4.0.2",
"regenerator-runtime": "0.13.7",
"resolve-url-loader": "3.1.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ export function getStylesConfig(wco: WebpackConfigOptions) {
{
loader: require.resolve('postcss-loader'),
options: {
implementation: require('postcss'),
postcssOptions: postcssOptionsCreator(componentsSourceMap, false),
},
},
Expand Down Expand Up @@ -242,6 +243,7 @@ export function getStylesConfig(wco: WebpackConfigOptions) {
{
loader: require.resolve('postcss-loader'),
options: {
implementation: require('postcss'),
postcssOptions: postcssOptionsCreator(globalSourceMap, buildOptions.extractCss),
},
},
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9253,16 +9253,16 @@ [email protected]:
read-cache "^1.0.0"
resolve "^1.1.7"

postcss-loader@4.1.0:
version "4.1.0"
resolved "https://registry.yarnpkg.com/postcss-loader/-/postcss-loader-4.1.0.tgz#4647a6c8dad3cb6b253fbfaa21d62201086f6e39"
integrity sha512-vbCkP70F3Q9PIk6d47aBwjqAMI4LfkXCoyxj+7NPNuVIwfTGdzv2KVQes59/RuxMniIgsYQCFSY42P3+ykJfaw==
postcss-loader@4.2.0:
version "4.2.0"
resolved "https://registry.yarnpkg.com/postcss-loader/-/postcss-loader-4.2.0.tgz#f6993ea3e0f46600fb3ee49bbd010448123a7db4"
integrity sha512-mqgScxHqbiz1yxbnNcPdKYo/6aVt+XExURmEbQlviFVWogDbM4AJ0A/B+ZBpYsJrTRxKw7HyRazg9x0Q9SWwLA==
dependencies:
cosmiconfig "^7.0.0"
klona "^2.0.4"
loader-utils "^2.0.0"
schema-utils "^3.0.0"
semver "^7.3.2"
semver "^7.3.4"

postcss-merge-longhand@^4.0.11:
version "4.0.11"
Expand Down Expand Up @@ -10592,7 +10592,7 @@ [email protected]:
resolved "https://registry.yarnpkg.com/semver/-/semver-7.0.0.tgz#5f3ca35761e47e05b206c6daff2cf814f0316b8e"
integrity sha512-+GB6zVA9LWh6zovYQLALHwv5rb2PHGlJi3lfiqIHxR0uuwCgefcOJc59v9fv1w8GbStwxuuqqAjI9NMAOOgq1A==

[email protected], semver@^7.0.0, semver@^7.1.1, semver@^7.3.2:
[email protected], semver@^7.0.0, semver@^7.1.1, semver@^7.3.2, semver@^7.3.4:
version "7.3.4"
resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.4.tgz#27aaa7d2e4ca76452f98d3add093a72c943edc97"
integrity sha512-tCfb2WLjqFAtXn4KEdxIhalnRtoKFN7nAwj0B3ZXCbQloV2tq5eDbcTmT68JJD3nRJq24/XgxtQKFIpQdtvmVw==
Expand Down

0 comments on commit f925099

Please sign in to comment.