fix(@angular-devkit/build-angular): enable dynamic import parsing wit…

…h serve localization Fixes #16248
angular · Nov 27, 2019 · 8bcdbff · 8bcdbff
1 parent 51d90bc
commit 8bcdbff
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/angular_devkit/build_angular/src/dev-server/index.ts b/packages/angular_devkit/build_angular/src/dev-server/index.ts
@@ -367,6 +367,9 @@ async function setupLocalize(
             translationIntegrity: localeDescription && localeDescription.integrity,
           }),
           plugins,
+          parserOpts: {
+            plugins: ['dynamicImport'],
+          },
         },
       },
     ],

diff --git a/tests/legacy-cli/e2e/tests/i18n/legacy.ts b/tests/legacy-cli/e2e/tests/i18n/legacy.ts
@@ -57,6 +57,7 @@ export const langTranslations = [
   },
 ];
 export const sourceLocale = langTranslations[0].lang;
+
 export const externalServer = (outputPath: string) => {
   const app = express();
   app.use(express.static(resolve(outputPath)));
@@ -87,6 +88,13 @@ export async function setupI18nConfig(useLocalize = true) {
     <p id="plural" i18n>Updated {minutes, plural, =0 {just now} =1 {one minute ago} other {{{minutes}} minutes ago}}</p>
   `);
 
+  // Add a dynamic import to ensure syntax is supported
+  // ng serve support: https://github.com/angular/angular-cli/issues/16248
+  await writeFile('src/app/dynamic.ts', `export const abc = 5;`);
+  await appendToFile('src/app/app.component.ts', `
+    (async () => { await import('./dynamic'); })();
+  `);
+
   // Add e2e specs for each lang.
   for (const { lang, translation } of langTranslations) {
     await writeFile(`./e2e/src/app.${lang}.e2e-spec.ts`, `