Skip to content

Commit

Permalink
feat(@angular/cli): add in-browser development error overlay
Browse files Browse the repository at this point in the history
Close #4513
  • Loading branch information
Charles Lyding authored and filipesilva committed Feb 15, 2017
1 parent dd5dda6 commit 7ea8013
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"url-loader": "^0.5.7",
"walk-sync": "^0.3.1",
"webpack": "~2.2.0",
"webpack-dev-server": "~2.2.0",
"webpack-dev-server": "~2.3.0",
"webpack-merge": "^2.4.0",
"zone.js": "^0.7.2"
},
Expand Down
1 change: 1 addition & 0 deletions packages/@angular/cli/custom-typings.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ interface IWebpackDevServerConfigurationOptions {
https?: boolean;
key?: string;
cert?: string;
overlay?: boolean;
}

interface WebpackProgressPluginOutputOptions {
Expand Down
2 changes: 1 addition & 1 deletion packages/@angular/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"url-loader": "^0.5.7",
"walk-sync": "^0.3.1",
"webpack": "~2.2.0",
"webpack-dev-server": "~2.2.0",
"webpack-dev-server": "~2.3.0",
"webpack-merge": "^2.4.0",
"zone.js": "^0.7.2"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/@angular/cli/tasks/serve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ export default Task.extend({
watchOptions: {
poll: projectConfig.defaults && projectConfig.defaults.poll
},
https: serveTaskOptions.ssl
https: serveTaskOptions.ssl,
overlay: serveTaskOptions.target === 'development'
};

if (sslKey != null && sslCert != null) {
Expand Down

0 comments on commit 7ea8013

Please sign in to comment.