fix(@angular-devkit/build-angular): support hidden component styleshe…

…et sourcemaps with esbuild builder The hidden stylesheet option was incorrectly being ignored for component stylesheets when using the experimental esbuild-based browser application builder. The hidden option will now correctly not include the stylesheet comment within the stylesheet text for components. (cherry picked from commit 53e9c45)
angular · Jul 1, 2022 · 74dbd5f · 74dbd5f
1 parent e5e07ff
commit 74dbd5f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts b/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts
@@ -306,7 +306,11 @@ async function bundleCode(
         {
           workspaceRoot,
           optimization: !!optimizationOptions.styles.minify,
-          sourcemap: !!sourcemapOptions.styles,
+          sourcemap:
+            // Hidden component stylesheet sourcemaps are inaccessible which is effectively
+            // the same as being disabled. Disabling has the advantage of avoiding the overhead
+            // of sourcemap processing.
+            !!sourcemapOptions.styles && (sourcemapOptions.hidden ? false : 'inline'),
           outputNames,
         },
       ),

diff --git a/packages/angular_devkit/build_angular/src/builders/browser-esbuild/stylesheets.ts b/packages/angular_devkit/build_angular/src/builders/browser-esbuild/stylesheets.ts
@@ -14,7 +14,7 @@ export interface BundleStylesheetOptions {
   workspaceRoot?: string;
   optimization: boolean;
   preserveSymlinks?: boolean;
-  sourcemap: boolean | 'external';
+  sourcemap: boolean | 'external' | 'inline';
   outputNames?: { bundles?: string; media?: string };
 }