Skip to content

Commit

Permalink
fix(@angular/cli): remove no-bin-links during npm/yarn install
Browse files Browse the repository at this point in the history
Previously we passed `--no-bin-links` because we used to install packages globally in some cases. But now this is no longer needed as we should now have permissions to generate "local" bin links even during a temp installations as these  will no longer generate bin links in the global context.

Fixes #16133
  • Loading branch information
alan-agius4 authored and mgechev committed Nov 12, 2019
1 parent 6c1ab62 commit 6c2d956
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/angular/cli/tasks/install-package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ interface PackageManagerOptions {
saveDev: string;
install: string;
prefix: string;
noBinLinks: string;
noLockfile: string;
}

Expand All @@ -39,7 +38,6 @@ export function installPackage(
packageManagerArgs.install,
packageName,
packageManagerArgs.silent,
packageManagerArgs.noBinLinks,
];

logger.info(colors.green(`Installing packages for tooling via ${packageManager}.`));
Expand Down Expand Up @@ -153,15 +151,13 @@ function getPackageManagerArguments(packageManager: PackageManager): PackageMana
saveDev: '--dev',
install: 'add',
prefix: '--modules-folder',
noBinLinks: '--no-bin-links',
noLockfile: '--no-lockfile',
}
: {
silent: '--quiet',
saveDev: '--save-dev',
install: 'install',
prefix: '--prefix',
noBinLinks: '--no-bin-links',
noLockfile: '--no-package-lock',
};
}

0 comments on commit 6c2d956

Please sign in to comment.