Skip to content

Commit

Permalink
fix(build): enable chunkhash in inline.js
Browse files Browse the repository at this point in the history
We had CommonsChunkPlugin misconfigured to remove the chunkhash in inline.js.

Partially address #2307
Close #2899
  • Loading branch information
filipesilva committed Oct 28, 2016
1 parent 0e91dfe commit 30cc482
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions packages/angular-cli/models/webpack-build-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ export function getWebpackCommonConfig(
}),
new webpack.optimize.CommonsChunkPlugin({
minChunks: Infinity,
name: 'inline',
filename: 'inline.js',
sourceMapFilename: 'inline.map'
name: 'inline'
}),
new GlobCopyWebpackPlugin({
patterns: appConfig.assets,
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/third-party/bootstrap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function() {
.then(() => expectFileToMatch('dist/scripts.bundle.js', '/*!\\n * Bootstrap'))
.then(() => expectFileToMatch('dist/styles.bundle.js', '/*!\\n * Bootstrap'))
.then(() => expectFileToMatch('dist/index.html', oneLineTrim`
<script type="text/javascript" src="inline.js"></script>
<script type="text/javascript" src="inline.bundle.js"></script>
<script type="text/javascript" src="styles.bundle.js"></script>
<script type="text/javascript" src="scripts.bundle.js"></script>
<script type="text/javascript" src="main.bundle.js"></script>
Expand Down

0 comments on commit 30cc482

Please sign in to comment.