Skip to content

Commit

Permalink
refactor: remove reflect-metadata as a direct dependency (#3655)
Browse files Browse the repository at this point in the history
  • Loading branch information
clydin authored and hansl committed Feb 7, 2017
1 parent 5972f1a commit 2f5f74d
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 8 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"portfinder": "1.0.9",
"postcss-loader": "^0.9.1",
"raw-loader": "^0.5.1",
"reflect-metadata": "^0.1.8",
"resolve": "^1.1.7",
"rimraf": "^2.5.3",
"rsvp": "^3.0.17",
Expand Down
1 change: 0 additions & 1 deletion packages/@ngtools/webpack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"@angular/core": "^2.3.1",
"@angular/tsc-wrapped": "^0.5.0",
"typescript": "^2.0.2",
"reflect-metadata": "^0.1.8",
"webpack": "2.2.0"
}
}
2 changes: 0 additions & 2 deletions packages/@ngtools/webpack/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'reflect-metadata';

export * from './plugin';
export {ngcLoader as default} from './loader';
export {PathsPlugin} from './paths-plugin';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'reflect-metadata';
import 'core-js/es7/reflect';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {AppModule} from './app.module';

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/assets/webpack/test-app/app/main.jit.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'reflect-metadata';
import 'core-js/es7/reflect';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {AppModule} from './app.module';

Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/tests/packages/webpack/weird.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function(skipCleaning: () => void) {
.then(() => expectFileToExist('dist/0.app.main.js'))
.then(() => expectFileToExist('dist/1.app.main.js'))
.then(() => expectFileToExist('dist/2.app.main.js'))
.then(() => expectFileSizeToBeUnder('dist/app.main.js', 400000))
.then(() => expectFileSizeToBeUnder('dist/app.main.js', 410000))
.then(() => expectFileSizeToBeUnder('dist/0.app.main.js', 40000))

// Skip code generation and rebuild.
Expand All @@ -27,7 +27,7 @@ export default function(skipCleaning: () => void) {
.then(() => expectFileToExist('dist/0.app.main.js'))
.then(() => expectFileToExist('dist/1.app.main.js'))
.then(() => expectFileToExist('dist/2.app.main.js'))
.then(() => expectToFail(() => expectFileSizeToBeUnder('dist/app.main.js', 400000)))
.then(() => expectToFail(() => expectFileSizeToBeUnder('dist/app.main.js', 410000)))
.then(() => expectFileSizeToBeUnder('dist/0.app.main.js', 40000))
.then(() => skipCleaning());
}

0 comments on commit 2f5f74d

Please sign in to comment.