test: fix platform server e2e test

angular · Oct 25, 2019 · 125847b · 125847b
1 parent bf03a73
commit 125847b
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 12 deletions.
diff --git a/tests/legacy-cli/e2e/ng-snapshot/package.json b/tests/legacy-cli/e2e/ng-snapshot/package.json
@@ -12,6 +12,7 @@
     "@angular/localize": "github:angular/localize-builds#33c7636c27a4f147607cf5a9dbf8cc1f7235da99",
     "@angular/platform-browser": "github:angular/platform-browser-builds#ce1e659ca1354adb43047933dcd4197cbd96174f",
     "@angular/platform-browser-dynamic": "github:angular/platform-browser-dynamic-builds#d8664790dc89a1d30cf18788479cd5ccb1fb5ee6",
+    "@angular/platform-server": "github:angular/platform-server-builds#278e7555b936edf9d9292f75e67ba5b233bd285a",
     "@angular/router": "github:angular/router-builds#f75458fdef2ef233080332e0a96f4d0cbfad93e9"
   }
 }
diff --git a/tests/legacy-cli/e2e/tests/build/build-app-shell-with-schematic.ts b/tests/legacy-cli/e2e/tests/build/build-app-shell-with-schematic.ts
@@ -11,7 +11,7 @@ export default async function () {
   await updateJsonFile('package.json', packageJson => {
     const dependencies = packageJson['dependencies'];
     dependencies['@angular/platform-server'] = getGlobalVariable('argv')['ng-snapshots']
-      ? 'github:angular/platform-server-builds'
+      ? require('../../ng-snapshot/package.json').dependencies['@angular/platform-server']
       : readNgVersion();
   });
 

diff --git a/tests/legacy-cli/e2e/tests/build/build-app-shell.ts b/tests/legacy-cli/e2e/tests/build/build-app-shell.ts
@@ -9,7 +9,8 @@ export default function() {
   let platformServerVersion = readNgVersion();
 
   if (getGlobalVariable('argv')['ng-snapshots']) {
-    platformServerVersion = 'github:angular/platform-server-builds';
+    platformServerVersion = require('../../ng-snapshot/package.json')
+      .dependencies['@angular/platform-server'];
   }
 
   return Promise.resolve()

diff --git a/tests/legacy-cli/e2e/tests/build/platform-server.ts b/tests/legacy-cli/e2e/tests/build/platform-server.ts
@@ -14,7 +14,7 @@ export default async function () {
   await updateJsonFile('package.json', packageJson => {
     const dependencies = packageJson['dependencies'];
     dependencies['@angular/platform-server'] = getGlobalVariable('argv')['ng-snapshots']
-      ? 'github:angular/platform-server-builds'
+      ? require('../../ng-snapshot/package.json').dependencies['@angular/platform-server']
       : readNgVersion();
   });
 

diff --git a/tests/legacy-cli/e2e/tests/i18n/ivy-localize-server.ts b/tests/legacy-cli/e2e/tests/i18n/ivy-localize-server.ts
@@ -9,23 +9,34 @@ import {
   replaceInFile,
   writeFile,
 } from '../../utils/fs';
-import { ng, npm } from '../../utils/process';
+import { ng, silentNpm } from '../../utils/process';
 import { updateJsonFile } from '../../utils/project';
 import { expectToFail } from '../../utils/utils';
 import { readNgVersion } from '../../utils/version';
 
+const snapshots = require('../../ng-snapshot/package.json');
+
 export default async function () {
-  let localizeVersion = '@angular/localize@' + readNgVersion();
-  if (getGlobalVariable('argv')['ng-snapshots']) {
-    localizeVersion = require('../../ng-snapshot/package.json').dependencies['@angular/localize'];
-  }
+  const isSnapshotBuild = getGlobalVariable('argv')['ng-snapshots'];
 
-  await npm('install', `${localizeVersion}`);
+  await updateJsonFile('package.json', packageJson => {
+    const dependencies = packageJson['dependencies'];
+    dependencies['@angular/localize'] = isSnapshotBuild
+      ? snapshots.dependencies['@angular/localize']
+      : readNgVersion();
+  });
 
   // Add universal to the project
-  await ng('add', '@nguniversal/[email protected]');
+  await ng('add', '@nguniversal/[email protected]', '--skip-install');
+
+  if (isSnapshotBuild) {
+    await updateJsonFile('package.json', packageJson => {
+      const dependencies = packageJson['dependencies'];
+      dependencies['@angular/platform-server'] = snapshots.dependencies['@angular/platform-server'];
+    });
+  }
 
-  await npm('run', 'webdriver-update');
+  await silentNpm('install');
 
   const serverbaseDir = 'dist/test-project/server';
   const serverBuildArgs = ['run', 'test-project:server'];
@@ -34,7 +45,6 @@ export default async function () {
   const langTranslations = [
     { lang: 'en-US', translation: 'Hello i18n!' },
     { lang: 'fr', translation: 'Bonjour i18n!' },
-    { lang: 'de', translation: 'Hallo i18n!' },
   ];
 
   await updateJsonFile('angular.json', workspaceJson => {