Skip to content

fix(@angular/build): Ctrl + C not terminating dev-server with SSR #2036

fix(@angular/build): Ctrl + C not terminating dev-server with SSR

fix(@angular/build): Ctrl + C not terminating dev-server with SSR #2036

Workflow file for this run

name: Pull Request
on:
pull_request:
types: [opened, synchronize, reopened]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
permissions: {}
defaults:
run:
shell: bash
jobs:
analyze:
runs-on: ubuntu-latest
outputs:
snapshots: ${{ steps.filter.outputs.snapshots }}
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
persist-credentials: false
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: filter
with:
filters: |
snapshots:
- 'tests/legacy-cli/e2e/ng-snapshot/package.json'
lint:
runs-on: ubuntu-latest
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup ESLint Caching
uses: actions/cache@2cdf405574d6ef1f33a1d12acccd3ae82f47b3f2 # v4.1.0
with:
path: .eslintcache
key: ${{ runner.os }}-${{ hashFiles('.eslintrc.json') }}
- name: Install node modules
run: yarn install --immutable
- name: Generate JSON schema types
# Schema types are required to correctly lint the TypeScript code
run: yarn admin build-schema
- name: Run ESLint
run: yarn lint --cache-strategy content
- name: Validate NgBot Configuration
run: yarn ng-dev ngbot verify
- name: Validate Circular Dependencies
run: yarn ts-circular-deps check
- name: Run Validation
run: yarn admin validate
- name: Check Package Licenses
uses: angular/dev-infra/github-actions/linting/licenses@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Check tooling setup
run: yarn check-tooling-setup
- name: Check commit message
# Commit message validation is only done on pull requests as its too late to validate once
# it has been merged.
run: yarn ng-dev commit-message validate-range ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }}
- name: Check code format
# Code formatting checks are only done on pull requests as its too late to validate once
# it has been merged.
run: yarn ng-dev format changed --check ${{ github.event.pull_request.base.sha }}
build:
runs-on: ubuntu-latest
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel
uses: angular/dev-infra/github-actions/bazel/setup@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Install node modules
run: yarn install --immutable
- name: Build release targets
run: yarn ng-dev release build
- name: Store PR release packages
uses: actions/upload-artifact@604373da6381bf24206979c74d06a550515601b9 # v4.4.1
with:
name: packages
path: dist/releases/*.tgz
retention-days: 14
test:
runs-on: ubuntu-latest
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel
uses: angular/dev-infra/github-actions/bazel/setup@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Install node modules
run: yarn install --immutable
- name: Run module and package tests
run: yarn bazel test //modules/... //packages/...
e2e:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
node: [22]
subset: [npm, esbuild]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Install node modules
run: yarn install --immutable
- name: Setup Bazel
uses: angular/dev-infra/github-actions/bazel/setup@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Run CLI E2E tests
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
e2e-package-managers:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
node: [22]
subset: [yarn, pnpm]
shard: [0, 1, 2]
runs-on: ${{ matrix.os }}
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Install node modules
run: yarn install --immutable
- name: Setup Bazel
uses: angular/dev-infra/github-actions/bazel/setup@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Run CLI E2E tests
run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
e2e-snapshots:
needs: analyze
if: needs.analyze.outputs.snapshots == 'true'
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
node: [18]
subset: [npm, esbuild]
shard: [0, 1, 2, 3, 4, 5]
runs-on: ${{ matrix.os }}
steps:
- name: Initialize environment
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Install node modules
run: yarn install --immutable
- name: Setup Bazel
uses: angular/dev-infra/github-actions/bazel/setup@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Setup Bazel RBE
uses: angular/dev-infra/github-actions/bazel/configure-remote@46771fcd70e08e7ba3c30f4ee9ebf9971b7fdb5c
- name: Run CLI E2E tests
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}