feat(uiSrefActive): nested state and DOM decendant support for ui-sref-active

[MrOrz]

uiSrefActive now takes all decendant uiSrefs into consideration.
uiSrefActive also adds a class with -nested postfix when a child state of the related uiSrefs becomes active.

Implemented the consensus we previously met in #704.

[MrOrz]

Not sure if the $timeout hack should be replaced with $evalAsync instead.

http://stackoverflow.com/questions/17301572/angularjs-evalasync-vs-timeout

[nateabele]

Not a huge fan of this implementation. It seems like it:

• Contains a lot more code than it should to solve the original problem statement
• Contains 'magical' classes
• Uses events where you wouldn't need any if you had a good directive controller design.

Not sure if the $timeout hack should be replaced with $evalAsync instead.

Nope.

[timkindberg]

I am a fan of the what is trying to be achieved though, more so than #819.

[nateabele]

[M]ore so than #819.

Two completely different problems.

[timkindberg]

It is? I gathered that they were the same.

From the PR description above...

uiSrefActive also adds a class with -nested postfix when a child state of the related uiSrefs becomes active

From #819...

This issue provides support for optionally counting a link as active if any of its child states are active and parameters match.

I thought they were both solving the same problem—activate a ui-sref link when its child state becomes active—but in two different ways. #819 just activates it, whereas this PR gives it a different active class, e.g. '-nested' postfix.

[MrOrz]

Contains a lot more code than it should to solve the original problem statement
Contains 'magical' classes
Uses events where you wouldn't need any if you had a good directive controller design.

In #704 @besnik81 provided his implementation on the same problem, which does not have the three problems @nateabele addressed above.

Here is @besnik81's implementation : https://github.com/besnik81/ui-router/compare/patch-2

It does the following:

• Provides the ability to nest uiSrefActive and is able to support nested state with a few modification on one single function. (More specifically, the if-statement in checkNotifySrefActive)
• Supports ui-sref-active="is-active|is-parent-active" syntax.
• Recursively traverse the directive controller upwards. No events used.

If my implementation is not good enough, please take a look at @besnik81 's. It's a solution to both #818 (targeting nested-states) and #704 (mentioning DOM hierarchy as well) .

[tomekpiotrowski]

What is the current status of:

uiSrefActive now takes all decendant uiSrefs into consideration.

?

From what I can see it is still not implemented in master - only the last child uiSref is considered. I can provide a PR that implements this functionality on top of current master if needed.

[timkindberg]

@tomekpiotrowski oh you may be right. Sure submit a PR if you like.

[ProLoser]

Thoughts on #818 #819 and any other related ones:

ui-is-sref="active-class" for exact matches and ui-has-sref="active-class" for loose matches. Frankly if you want to make this whole thing any more complicated you might as well point people to just do ng-class="...$state.contains(...)"

[timkindberg]

We already have ui-sref-active for fuzzy matches and ui-sref-active-eq for exact.

[stale]

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues
may be reopened.

Thank you for your contributions.