Fixes #125 Add reloadOnSearch property to stateConfig

[thoreinstein]

reloadOnSearch when set to false, allows the user to modify the search portion of $location without reloading or reactivating a state.

[timkindberg]

It says build failed, but that failing test is not the one we wrote and was already failing before we added our stuff in.

[timkindberg]

@nateabele one thing I did want to point out in the code as a potential concern (though all tests are passing so we aren't too worried) is that when we were modifying the url with $location.search() it would trigger a state change because the url changed, and although to did equal from because we were going to the same state, we noticed that locals no longer equaled from.locals and it had us stumped and we never could figure out why those would no longer be equal. So our solution was to split that particular expression into its own group within the if statement.

You can see how our if statement require to to equal from, but then after that its either of the other two expressions, not both. I've spaced the statement out onto separate lines for easier comprehension.

if ( 
   to === from && 
   ( 
       (locals === from.locals && !options.reload) || 
       (to.self.reloadOnSearch === false)
   ) 
)

So in essence reloadOnSearch doesn't necessarily care about the $location.search() value, it could potentially be used for other purposes of traveling to the same state without reloading.

Also I'm wondering if we should have tied this in with options.reload somehow.

[nateabele]

I'd rewrite that as if (shouldTriggerReload(to, from, locals options)) { ..., and then extract the condition out into a function.

Also, the tests are failing because the list of states changed. Honestly, we should probably rewrite that test since it's pretty brittle in its current form, but just add 'RS' to that list for now in the proper position. Don't forget to squash your commits.

[timkindberg]

@nateabele good idea on the refactor, will be much easier to read that way.

@janders223 you got this? You've already got the repo pulled down. Need to refactor the if and add 'RS' to the list of states in the breaking test.

[thoreinstein]

@timkindberg I'll get on it

[thoreinstein]

That should pass the build now.

[nateabele]

Looks good. Squash your commits and we'll roll it.

[timkindberg]

Thanks Jim!