$destroy event is triggered before animation ends #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teemu
changed the title
when view is animated using ngAnimate, $destroy event is triggered before animation ends. closes angular-ui#1643
Teemu
force-pushed
the
destroy-event-triggered-before-animation-ends
branch
from
02cb293 to
1be1379
Compare
|
@Frozenball Pro. |
nateabele
added a commit
that referenced
this pull request
Oct 30, 2015
…ore-animation-ends $destroy event is triggered before animation ends
|
@Frozenball @ghoullier @philBrown @SmuliS @petermolyneux We're going to revert this PR, as deferring the scope destruction has caused all sorts of lifecycle issues. Can you pull/build PR #2596 (pre 1.0.0-alpha.1) or PR #2597 (pre 0.2.19) and try using the Let me know if the animation promise will satisfy your use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1643