Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.8+ is creating duplicate <ui-view> nodes #958

Closed
ProLoser opened this issue Mar 12, 2014 · 17 comments
Closed

0.2.8+ is creating duplicate <ui-view> nodes #958

ProLoser opened this issue Mar 12, 2014 · 17 comments

Comments

@ProLoser
Copy link
Member

screen shot 2014-03-11 at 7 15 20 pm

Note the node at the top and bottom of the page. Note the duplicate nodes that have been nested. The top one under <body> is the original node I created, but it contains no data and no DOM elements. The second version at the bottom of the page (injected after my scripts) contains both data and the rest of the app.

This does not occur on v0.2.7
@ProLoser
Copy link
Member Author

Also, I have 0 errors and have no idea what's causing this.

@timkindberg
Copy link
Contributor

This will probably be fixed by all the ui-view updates that will come out in 0.2.9

@christopherthielen
Copy link
Contributor

@ProLoser Are you using latest master with #858 ?
@timkindberg since 0.2.9 was tagged for bower, will the next release be 0.3.0?

@adrianboimvaser
Copy link

I'm having the same issue. I built master from source.
@christopherthielen 0.2.9 is really just 0.2.8.

@ProLoser
Copy link
Member Author

@adrianboimvaser you had this problem AFTER building?

@christopherthielen as @adrianboimvaser states, 0.2.9 is just 0.2.8, I just retagged it because people wouldn't stop wining.

@ProLoser
Copy link
Member Author

@timkindberg i think this is CAUSED by the view updates. This doesn't occur when there is no <!-- ui-view-anchor --> which I believe is the new code.

@adrianboimvaser
Copy link

@ProLoser yes, I have this problem with latest revision from master.

@adrianboimvaser
Copy link

<!-- ui-view-anchor -->? what's that?

@ProLoser
Copy link
Member Author

@adrianboimvaser look at my screenshot and look inside of uiViewDirective.js and you'll fine ui-view-anchor. It's a new comment tag that is used to hold the place of the view while the ACTUAL view is being swapped in and out.

On a completely unrelated note: @nateabele I completely applaud the directive refactor. I really like your use of directive layering here. Even if it IS being a little buggy lol.

@adrianboimvaser
Copy link

capture
This is how my page looks like after a bunch of route changes.

@nateabele
Copy link
Contributor

Please update to 0.2.10 (just released) and try again. The directive has been rewritten to mirror the DOM behavior of ngView, and has such, has eliminated the use of anchor comments (as well as this issue, in all likelihood).

@adrianboimvaser
Copy link

Not fixed in 0.2.10, going back to 0.2.7 and dispensing with ui-sref-opts :(

@adrianboimvaser
Copy link

I'm curious about the version scheme this project is using. New features or big refactorings should increment the 2nd number (.x.) Changing the 3rd number should be reserved for bug fixes, not for changes with the potential for breaking client apps.

@nateabele
Copy link
Contributor

@ProLoser If this is still an issue, and you post a Plunkr or something that demonstrates it?

@nateabele
Copy link
Contributor

Yeah, I can't reproduce this at all on the latest release. I've tried clicking around the sample app a bunch of times, and everything works fine. No redundant uiViews produced. And again, to reiterate, the <!-- ui-view-anchor --> elements are no longer used, so if you're seeing those, you're still on the old version.

@ProLoser
Copy link
Member Author

ProLoser commented Mar 14, 2014 •
edited
Loading

Give me a minute to test too.

On Fri, Mar 14, 2014 at 1:08 PM, Nate Abele [email protected]:

Yeah, I can't reproduce this at all on the latest release. I've tried
clicking around the sample app a bunch of times, and everything works fine.
No redundant uiViews produced. And again, to reiterate, the elements are no longer used, so if you're seeing
those, you're still on the old version.

Reply to this email directly or view it on GitHubhttps://github.com//issues/958#issuecomment-37689885
.

@ProLoser
Copy link
Member Author

@nateabele sorry for the tardy response, my project wasn't compiling all weekend.

I just checked out v0.2.10 and the duplicate bug is gone!

I do however see quite a few of these: <!-- uiView: undefined -->, not that I care that much since it works, but I was curious what is causing the 'undefined' and if it's necessary is it possible to reconsider at least populating it with useful information (such as what state it's populated with).

@demetriusnunes demetriusnunes mentioned this issue Aug 5, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nateabele @ProLoser @timkindberg @adrianboimvaser @christopherthielen