Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-view does not work inside ng-if #857

Closed
meenie opened this issue Feb 4, 2014 · 1 comment
Closed

ui-view does not work inside ng-if #857

meenie opened this issue Feb 4, 2014 · 1 comment

Comments

@meenie
Copy link
Contributor

meenie commented Feb 4, 2014

When you put a ui-view directive inside a ng-if it does not properly bootstrap the element and it completely fails.
@meenie meenie mentioned this issue Feb 4, 2014
Closed
meenie pushed a commit to meenie/ui-router that referenced this issue Feb 4, 2014
Fix for issue angular-ui#857
3106953 
Use the linking function element instead of the template element when setting the parent.
This was referenced Feb 4, 2014
Merged
Closed
meenie pushed a commit to meenie/ui-router that referenced this issue Feb 4, 2014
fix(uiView): Properly handle uiView within a ngIf
67098a7 
Use the linking function element instead of the template element.

Closes angular-ui#857
@timkindberg
Copy link
Contributor

Duplicate #552

meenie pushed a commit to meenie/ui-router that referenced this issue Mar 3, 2014
fix(uiView): Properly handle uiView within a ngIf
9d2e80a 
Use the linking function element instead of the template element.

Closes angular-ui#857
meenie pushed a commit to meenie/ui-router that referenced this issue Mar 3, 2014
fix(uiView): Refactoring uiView directive to copy ngRoute logic
ae23e7c 
- Changed the structure of the uiView directive to work more like ngRoute.
- Updated tests to work with new structure.
- Fixes the issue with using ngIf in conjunction with uiView.
- Added in extensive test for ngIf fix.

Closes angular-ui#857
meenie pushed a commit to meenie/ui-router that referenced this issue Mar 3, 2014
fix(uiView): Refactoring uiView directive to copy ngView logic
9bfffb6 
- Changed the structure of the uiView directive to work more like ngView.
- Updated tests to work with new structure.
- Fixes the issue with using ngIf in conjunction with uiView.
- Added in extensive test for ngIf fix.

Closes angular-ui#857
meenie pushed a commit to meenie/ui-router that referenced this issue Mar 4, 2014
fix(uiView): Refactoring uiView directive to copy ngView logic
72d5907 
- Changed the structure of the uiView directive to work more like ngView.
- Updated tests to work with new structure.
- Fixes the issue with using ngIf in conjunction with uiView.
- Added in extensive test for ngIf fix.

Closes angular-ui#857, angular-ui#552
meenie pushed a commit to meenie/ui-router that referenced this issue Mar 6, 2014
fix(uiView): Refactoring uiView directive to copy ngView logic
548fab6 
 - Changed the structure of the uiView directive to work more like ngView.
 - Updated tests to work with new structure.
 - Updated tests so that all assertions actually run through AngularJS 1.0.8.
 - Added in extensive test for ngIf fix.
 - Added in ability for uiView to work with ngIf, ngRepeat, and ngClass.
 - Updated base AngularJS version to 1.2.14 to test $animate callbacks in 1.2.*
 - Fixes controllerAs so that it will work within a view declaration.

Closes angular-ui#857, angular-ui#552
@lorenzofox3 lorenzofox3 mentioned this issue Jan 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timkindberg @meenie