Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Glob docs #2965

Closed
christopherthielen opened this issue Sep 2, 2016 · 0 comments
Closed

Improve Glob docs #2965

christopherthielen opened this issue Sep 2, 2016 · 0 comments
Labels
1.0 docs
Milestone
1.0.0-beta.2

Comments

@christopherthielen
Copy link
Contributor

Globbing patterns are commonly misunderstood.
The glob docs should be rewritten, centralized with examples (on the Glob class)
@christopherthielen christopherthielen modified the milestones: 1.0.0-final, 1.0.0-beta.2 Sep 2, 2016
christopherthielen added a commit that referenced this issue Sep 9, 2016
@christopherthielen
refactor(Glob): BC-BREAK Use RegExp to implement Glob SWITCH glob to …
d1dff31 
…use RegExp

Previously, trailing single wildcards '*' could be "zero-length" matches.
The glob `foo.*` would match `foo` and `foo.bar` but not `foo.bar.baz`.
Likewise, the glob `foo.*.*` would also match `foo`.

Now, all single wildcards match one segment.
The glob `foo.*` matches `foo.bar` but does not match `foo`.
Use `foo.**` instead to match zero or more segments.

test(Glob): Add more glob tests
docs(Glob): Document glob
Closes #2965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 docs
Projects
None yet
Milestone
1.0.0-beta.2
Development

No branches or pull requests
1 participant
@christopherthielen