-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Angular 1.5 components as routes #2547
Comments
Looks like the change was added to ngView here: |
Looks like it will need to be added here: https://github.com/angular-ui/ui-router/blob/master/src/viewDirective.js |
thanks, yes this is definitely on our radar. Targeting 1.0-beta |
Looks like 1.0alpha was merged to master after I left the previous comment. Looks like the change would be here for angular 1: https://github.com/angular-ui/ui-router/blob/master/src/ng1/viewDirective.ts Was wondering if there was a timeframe for the beta? Thanks! |
@christopherthielen Tried it out on the legacy branch with this commit (jonricaurte@a4cab7d) and seems to work. Will work on a PR with tests. Does not seem like anything else needs to be added. |
This is possible, but it would be nice to have |
Would love to have this sooner rather than later |
Yes, please, |
+1 |
+1 for $resolve |
Also, $resolve should not only be available in state templates, but also in UI Bootstrap modals :) |
UI-Router 0.2.18 routing to angular 1.5 The guts are here:
|
I'm using 1.0.0 alpha 4 but the binding to .component does not work. The milestone of this issue was set to 1.0.0 alpha 1 though. Is this implemented or not? |
@bitflower yes 1.0.0-alpha.4 should route to component. Can I see your code? |
It works, it was my mistake. Sorry but thanks! |
Heads up to anyone else who finds this plunkr above ☝️ it has a bug. It needs to kebob the attribute keys @christopherthielen hopefully you'll consider backporting the code here to legacy its super hard to convince people to let you install an 1.0 alpha version to get component routing. or atleast put that in a bower repo somewhere for me to include more formally. |
@trashhalo @Jared314 @fetters5 Use this polyfill for legacy branch: https://github.com/softsimon/ui-router-route-to-components |
Make ui-router have a similar feature as ngRoute does here using angular 1.5:
https://docs.angularjs.org/guide/component#components-as-route-templates
The text was updated successfully, but these errors were encountered: