Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref is not defined using ui-sref-active with ui-state #2488

Closed
arcxyz opened this issue Jan 26, 2016 · 3 comments
Closed

ref is not defined using ui-sref-active with ui-state #2488

arcxyz opened this issue Jan 26, 2016 · 3 comments
Labels
1.0 bug PR-Wanted
Milestone
1.0.0-alpha.1

Comments

@arcxyz
Copy link

arcxyz commented Jan 26, 2016

When combining the new uiState directive with uiSrefActive I get an error. It is related with this line of code where ref is not defined:

ui-router/src/stateDirectives.js

Line 181 in 87f10df

if (active) active.$$addStateInfo(ref.state, def.params);

@eddiemonge
Copy link
Contributor

@nateabele Is that a typo?

@nateabele
Copy link
Contributor

Weird... looks like yeah.

@christopherthielen christopherthielen modified the milestones: after 0.2.17, 1.0.0-alpha.1 Jan 27, 2016
@christopherthielen christopherthielen mentioned this issue Feb 1, 2016
Closed
@christopherthielen
Copy link
Contributor

Apparently we could use some more coverage for the new directive

jrcPinappol added a commit to jrcPinappol/ui-router that referenced this issue Feb 1, 2016
@jrcPinappol
fix(uiState): Corrected variable (angular-ui#2488, angular-ui#2508)
b8f3c14
christopherthielen added a commit that referenced this issue Feb 1, 2016
@christopherthielen
Merge pull request #2511 from dEradicated/master
d482cc8 
fix(uiState): Corrected variable (#2488, #2508)
christopherthielen added a commit that referenced this issue Feb 14, 2016
@christopherthielen
fix(ui-state): update ui-sref-active/eq info
abb3deb 
when ui-state dynamicly changes watchers, make sure to update the ui-sref-active/eq
Closes #2488
ExpFront pushed a commit to ExpFront/ui-router that referenced this issue Jun 23, 2016
@jrcPinappol @ExpFront
fix(uiState): Corrected variable (angular-ui#2488, angular-ui#2508)
8699107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 bug PR-Wanted
Projects
None yet
Milestone
1.0.0-alpha.1
Development

No branches or pull requests
4 participants
@nateabele @eddiemonge @arcxyz @christopherthielen