Skip to content

Commit

Permalink
fix(bower.json): fixes bower.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@0x-r4bbit
0x-r4bbit committed Jan 16, 2014
1 parent c3a846c commit eed3cc4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bower.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
},
"ignore": [
"**/.*",
"*.js"
"*.js",
"node_modules",
"bower_components",
"component.json",
"package.json"
"package.json",
"lib",
"config",
"sample",
Expand Down

10 comments on commit eed3cc4

@msafi
Copy link

@msafi msafi commented on eed3cc4 Jan 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude, JS files don't install anymore! Or something...

The release/ directory is empty...

@0x-r4bbit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msafi what has that to do with this PR?

@damienklinnert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msafi +1

@msafi
Copy link

@msafi msafi commented on eed3cc4 Jan 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PascalPrecht Looks like you fixed the line that tells bower to ignore all your project's JS files. Now when I install through bower, I don't get any JavaScript files...

@0x-r4bbit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msafi hah! Good catch! Actually, I fixed the bower.json to get the project installed locally. Pinging @nateabele here.

@nateabele
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, so (since I don't use Bower and I have no idea) what needs to happen here?

@msafi
Copy link

@msafi msafi commented on eed3cc4 Jan 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nateabele I'm not sure, but I think the ignore section of bower.json specifies patterns for files that you want Bower to ignore when a user does bower install. It's now ignoring all JS files because of the *.js pattern. So, delete line 10.

@nateabele
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, is there any way to test this before I just do it?

@eduardomb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nateabele Just remove the "*.js" from ignore and you're good (PR: #768). To test it yourself:

  1. commit the fix on you local git folder (you're gonna need the sha1 of this commit on next step)
  2. install the package with bower (cd /tmp/ && bower install /path/to/local/repository#SHA1 )
  3. Open /tmp/bower_components/angular-ui-router/releases and check if its not empty.

It would be nice if you could create a new tag 0.2.9 for this fix. So that I can type bower install angular-ui-router#0.2.9 instead of using the SHA1

@shairez
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any updates? need help with anything?

Please sign in to comment.